Improved static analysis

Author: GrahamCampbell

.gitattributes

@@ -10,6 +10,7 @@
 /phpstan.src.neon.dist export-ignore
 /phpstan.tests.neon.dist export-ignore
 /phpunit.xml.dist export-ignore
+/psalm-baseline.xml export-ignore
 /psalm.xml export-ignore
 /README.md export-ignore
 /UPGRADING.md export-ignore

Makefile

@@ -14,6 +14,9 @@ phpstan-analyze-tests:
 psalm-analyze:
 	@docker run -it -w /data -v ${PWD}:/data:delegated --entrypoint vendor/bin/psalm.phar --rm registry.gitlab.com/grahamcampbell/php:7.4-cli
 
+psalm-baseline:
+	@docker run -it -w /data -v ${PWD}:/data:delegated --entrypoint vendor/bin/psalm.phar --rm registry.gitlab.com/grahamcampbell/php:7.4-cli --set-baseline=psalm-baseline.xml
+
 psalm-show-info:
 	@docker run -it -w /data -v ${PWD}:/data:delegated --entrypoint vendor/bin/psalm.phar --rm registry.gitlab.com/grahamcampbell/php:7.4-cli --show-info=true
 

psalm-baseline.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<files psalm-version="4.2.1@ea9cb72143b77e7520c52fa37290bd8d8bc88fd9">
+  <file src="src/Parser/EntryParser.php">
+    <MissingClosureReturnType occurrences="1">
+      <code>static function (array $data) {</code>
+    </MissingClosureReturnType>
+  </file>
+  <file src="src/Repository/RepositoryBuilder.php">
+    <InvalidStringClass occurrences="3">
+      <code>$adapter::create()</code>
+      <code>$reader::create()</code>
+      <code>$writer::create()</code>
+    </InvalidStringClass>
+    <MissingClosureReturnType occurrences="3">
+      <code>static function ($adapter) {</code>
+      <code>static function ($reader) {</code>
+      <code>static function ($writer) {</code>
+    </MissingClosureReturnType>
+  </file>
+  <file src="src/Util/Regex.php">
+    <UndefinedFunction occurrences="1">
+      <code>\preg_last_error_msg()</code>
+    </UndefinedFunction>
+  </file>
+</files>

psalm.xml

@@ -1,10 +1,11 @@
 <?xml version="1.0"?>
 <psalm
-    errorLevel="4"
+    errorLevel="2"
     resolveFromConfigFile="true"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    errorBaseline="psalm-baseline.xml"
 >
     <projectFiles>
         <directory name="src" />

vendor-bin/phpstan/composer.json

@@ -3,7 +3,7 @@
         "phpstan/phpstan": "0.12.58",
         "phpstan/extension-installer": "1.0.5",
         "phpstan/phpstan-deprecation-rules": "0.12.5",
-        "phpstan/phpstan-phpunit": "~0.12.11",
+        "phpstan/phpstan-phpunit": "0.12.16",
         "phpstan/phpstan-strict-rules": "0.12.5",
         "thecodingmachine/phpstan-strict-rules": "0.12.1"
     },