Loader: streamline isComment() with whitespace test (#212)

jrchamp · GrahamCampbell · commit e5a077e823e5 · 2016-11-28T23:08:37.000Z
Streamline isComment
diff --git a/src/Loader.php b/src/Loader.php
@@ -147,7 +147,9 @@ protected function readLinesFromFile($filePath)
      */
     protected function isComment($line)
     {
-        return strpos(ltrim($line), '#') === 0;
+        $line = ltrim($line);
+
+        return isset($line[0]) && $line[0] === '#';
     }
 
     /**
diff --git a/tests/fixtures/.env b/tests/fixtures/.env
@@ -3,3 +3,4 @@ BAR=baz
 SPACED=with spaces
 
 NULL=
+  

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,9 @@ protected function readLinesFromFile($filePath)`
`147`	`147`	`*/`
`148`	`148`	`protected function isComment($line)`
`149`	`149`	`{`
`150`		`- return strpos(ltrim($line), '#') === 0;`
	`150`	`+ $line = ltrim($line);`
	`151`	`+`
	`152`	`+ return isset($line[0]) && $line[0] === '#';`
`151`	`153`	`}`
`152`	`154`
`153`	`155`	`/**`