abs(h) symmetry

Author: WrathfulSpatula

PyQrackIsing/_pyqrack_ising.cpp

@@ -67,7 +67,7 @@ static inline double expected_closeness_weight(size_t n_rows, size_t n_cols, siz
 static inline std::vector<double> probability_by_hamming_weight(double J, double h, double z, double theta, double t, size_t n_qubits)
 {
     // critical angle
-    const double theta_c = std::asin(std::max(-1.0, std::min(1.0, (std::abs(z * J) >= (std::numeric_limits<double>::epsilon() / 2)) ? h / (z * J) : (J > 0 ? 1.0 : -1.0))));
+    const double theta_c = std::asin(std::max(-1.0, std::min(1.0, (std::abs(z * J) >= (std::numeric_limits<double>::epsilon() / 2)) ? std::abs(h) / (z * J) : (J > 0 ? 1.0 : -1.0))));
     const double delta_theta = theta - theta_c;
     std::vector<double> bias;
     if (std::abs(h) < 1e-12) {

scripts/generate_tfim_samples.py

@@ -114,7 +114,7 @@ def main():
     # Coordination number for a square lattice:
     z = 4
     # Mean-field critical angle (in radians)
-    theta_c = math.asin(max(min(1, h / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
+    theta_c = math.asin(max(min(1, abs(h) / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
     # Set theta relative to that:
     delta_theta = theta - theta_c
 

scripts/tfim_model_fit.py

@@ -270,7 +270,7 @@ def main():
     # Coordination number for a square lattice:
     z = 4
     # Mean-field critical angle (in radians)
-    theta_c = math.asin(max(min(1, h / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
+    theta_c = math.asin(max(min(1, abs(h) / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
     # Set theta relative to that:
     delta_theta = theta - theta_c
 

scripts/tfim_solver_functions.py

@@ -102,7 +102,7 @@ def tfim_magnetization(J=-1.0, h=2.0, z=4, theta=math.pi/18, t=5, n_qubits=16):
     omega *= math.pi
 
     # Mean-field critical angle (in radians)
-    theta_c = math.asin(max(min(1, h / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
+    theta_c = math.asin(max(min(1, abs(h) / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
     # Set theta relative to that:
     delta_theta = theta - theta_c
 
@@ -173,7 +173,7 @@ def generate_samples(J=-1.0, h=2.0, z=4, theta=math.pi/18, t=5, n_qubits=16, sho
     qubits = list(range(n_qubits))
 
     # Mean-field critical angle (in radians)
-    theta_c = math.asin(max(min(1, h / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
+    theta_c = math.asin(max(min(1, abs(h) / (z * J)) if np.isclose(z * J, 0) else (1 if J > 0 else -1), -1))
     # Set theta relative to that:
     delta_theta = theta - theta_c