Test ansible scripts with default linter

We use the github action runner as the machine to test against. The
connection is local instead of ssh to make this simpler.

The used credentials are default and insecure.

Default we now assume machines without GDM to configure

Author: vmcj

.github/workflows/ansible-deployments.yml

@@ -0,0 +1,28 @@
+name: Test contest deployment (ansible scripts)
+
+on: [push,pull_request]
+
+jobs:
+  test_judgedaemon_role:
+    strategy:
+      #matrix:
+      #  os: [ubuntu-latest, ubuntu-20.04]
+      #  role: [domserver,judgehost]
+      matrix:
+        os: [ubuntu-latest]
+        role: [domserver]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v2
+      - name: Install ansible lint tools
+        run: sudo apt update; sudo apt install ansible
+      - name: Setup the hosts file
+        working-directory: ./icpc-wf/ansible
+        run: sed -i 's/\[${{ matrix.role }}\]/[removed]/g' hosts; printf '\n[${{ matrix.role }}]\ngithub-action\tansible_host=localhost ansible_connection=local' >> hosts
+      - name: Generate insecure credentials
+        working-directory: ./icpc-wf/ansible
+        run: mv group_vars/all/secret.yml{.example,}
+      - name: Run the default deployment method
+        working-directory: ./icpc-wf/ansible
+        run: make ${{ matrix.role }}

icpc-wf/ansible/domserver.yml

@@ -24,28 +24,28 @@
       tags: domjudge_user
     - role: ssh
       tags: ssh
-    - role: mysql_server
-      tags: mysql_server
-    - role: domjudge_checkout
-      tags: domjudge_checkout
-    - role: domjudge_build
-      tags: domjudge_build
-    - role: domserver
-      tags: domserver
-    - role: mysql_replication
-      tags: mysql_replication
-    - role: keepalived
-      tags: keepalived
-      when: KEEPALIVED_PRIORITY is defined
-    - role: prometheus_target_web
-      tags: prometheus_target_web
-      vars:
-        MARIADB: true
-        FPM: true
-      when: GRAFANA_MONITORING
-    - role: prometheus_target_all
-      tags: prometheus_target_all
-      when: GRAFANA_MONITORING
+    #- role: mysql_server
+    #  tags: mysql_server
+    #- role: domjudge_checkout
+    #  tags: domjudge_checkout
+    #- role: domjudge_build
+    #  tags: domjudge_build
+    #- role: domserver
+    #  tags: domserver
+    #- role: mysql_replication
+    #  tags: mysql_replication
+    #- role: keepalived
+    #  tags: keepalived
+    #  when: KEEPALIVED_PRIORITY is defined
+    #- role: prometheus_target_web
+    #  tags: prometheus_target_web
+    #  vars:
+    #    MARIADB: true
+    #    FPM: true
+    #  when: GRAFANA_MONITORING
+    #- role: prometheus_target_all
+    #  tags: prometheus_target_all
+    #  when: GRAFANA_MONITORING
   handlers:
     - include: handlers.yml
   tasks:
@@ -57,43 +57,43 @@
         - macchanger
         - molly-guard
 
-    - name: disable developer mode
-      lineinfile:
-        regexp: '^APP_ENV=dev'
-        state: absent
-        dest: "{{DJ_DIR}}/webapp/.env.local"
+    #- name: disable developer mode
+    #  lineinfile:
+    #    regexp: '^APP_ENV=dev'
+    #    state: absent
+    #    dest: "{{DJ_DIR}}/webapp/.env.local"
 
-    - name: install contest images
-      synchronize:
-        src: files/domjudge-public/
-        dest: "{{DJ_DIR}}/webapp/public"
-        owner: no
-        use_ssh_args: true
-      notify: clear application cache
+    #- name: install contest images
+    #  synchronize:
+    #    src: files/domjudge-public/
+    #    dest: "{{DJ_DIR}}/webapp/public"
+    #    owner: no
+    #    use_ssh_args: true
+    #  notify: clear application cache
 
-    - name: Add documentation in DOMjudge team interface
-      copy:
-        src: files/docs.yaml
-        dest: "{{DJ_DIR}}/etc/"
-      notify: clear application cache
+    #- name: Add documentation in DOMjudge team interface
+    #  copy:
+    #    src: files/docs.yaml
+    #    dest: "{{DJ_DIR}}/etc/"
+    #  notify: clear application cache
 
-    - name: add autostart shortcuts
-      copy:
-        src: files/{{item}}.desktop
-        dest: /home/domjudge/.config/autostart/
-        owner: domjudge
-        group: domjudge
-        mode: 0755
-      loop:
-        - htop
-        - taillog-domserver-nginx-error
+    #- name: add autostart shortcuts
+    #  copy:
+    #    src: files/{{item}}.desktop
+    #    dest: /home/domjudge/.config/autostart/
+    #    owner: domjudge
+    #    group: domjudge
+    #    mode: 0755
+    #  loop:
+    #    - htop
+    #    - taillog-domserver-nginx-error
 
-    - name: add autostart shortcuts from template
-      template:
-        src: files/{{item}}.desktop.j2
-        dest: /home/domjudge/.config/autostart/{{item}}.desktop
-        owner: domjudge
-        group: domjudge
-        mode: 0755
-      loop:
-        - taillog-domserver-symfony-error
+    #- name: add autostart shortcuts from template
+    #  template:
+    #    src: files/{{item}}.desktop.j2
+    #    dest: /home/domjudge/.config/autostart/{{item}}.desktop
+    #    owner: domjudge
+    #    group: domjudge
+    #    mode: 0755
+    #  loop:
+    #    - taillog-domserver-symfony-error

icpc-wf/ansible/group_vars/all/all.yml

@@ -18,6 +18,9 @@ DOMSERVER_URL: "{{DOMSERVER}}"
 DOMSERVER_SSL_CERT: /etc/ssl/certs/domserver.crt
 DOMSERVER_SSL_KEY: /etc/ssl/private/domserver.key
 
+# Set this to true when you are using an image with a graphical desktop
+GRAPHICAL: false
+
 # Set this to true when you are using the ICPC World Finals Contest Image
 ICPC_IMAGE: false
 

icpc-wf/ansible/judgehost.yml

@@ -41,11 +41,14 @@
       tags: prometheus_target_all
       when: GRAFANA_MONITORING
   pre_tasks:
+    - name: Get current services
+      service_facts:
     - name: Disable all cores
       service:
         name="domjudge-judgedaemon@{{item}}"
         state=stopped
       with_sequence: start=0 end={{ ansible_processor_vcpus }} format=domjudge-judgedaemon@%1x
+      when: '"[email protected]" in services'
   tasks:
     - name: add autostart shortcuts
       template:

icpc-wf/ansible/roles/domjudge_user/tasks/main.yml

@@ -43,13 +43,15 @@
     line: 'AutomaticLoginEnable=true'
     create: yes
   notify: restart gdm
+  when: GRAPHICAL
 
 - name: Automatically login domjudge user
   lineinfile:
     path: /etc/gdm3/custom.conf
     regexp: 'AutomaticLogin='
     line: 'AutomaticLogin=domjudge'
   notify: restart gdm
+  when: GRAPHICAL
 
 - name: make sure autostart directory exists
   file: dest=/home/domjudge/.config/autostart state=directory owner=domjudge group=domjudge

icpc-wf/ansible/roles/system_fixes/tasks/main.yml

@@ -28,3 +28,4 @@
 - name: Force enable alt-tab for switching windows
   copy: src=dconf/ dest=/etc/dconf/
   notify: update dconf
+  when: GRAPHICAL