Skip to content

Conversation

@0x4bs3nt
Copy link
Contributor

@0x4bs3nt 0x4bs3nt commented Jan 6, 2026

Summary

  • Add detection support for the Astro meta framework.
  • Includes signature detection, version extraction and tests with full signature coverage.

Features

  • Seven signatures to match against for Astro detection
  • Tests covering all seven signatures
  • Version extraction

Test plan

  • gofmt applied
  • framework unit tests passing (go test ./internal/scan/frameworks)
  • go vet passes
  • manually tested on Astro websites

Add detection support for the Astro meta framework.

Includes signature detection, version extraction and tests with full
signature coverage.
Copy link
Owner

@vmfunc vmfunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on the astro detection! tested locally and everything passes - unit tests, go vet, gofmt all good.

one small thing - the generator meta weight is 0.6 but all other meta-framework detectors use 0.5 as max:

  • next.js: __NEXT_DATA__ → 0.5
  • nuxt: __NUXT__ → 0.5
  • sveltekit: __sveltekit → 0.5
  • gatsby: ___gatsby → 0.5
  • remix: __remixContext → 0.5

left a suggestion on that line to match the convention. otherwise lgtm 👍

@vmfunc vmfunc added the blocked waiting for changes by author label Jan 6, 2026
Adjusted generator meta weight to remain consistent with other meta-framework detectors.

Co-authored-by: Celeste Hickenlooper <celeste@router.sex>
@0x4bs3nt
Copy link
Contributor Author

0x4bs3nt commented Jan 6, 2026

nice work on the astro detection! tested locally and everything passes - unit tests, go vet, gofmt all good.

one small thing - the generator meta weight is 0.6 but all other meta-framework detectors use 0.5 as max:

* next.js: `__NEXT_DATA__` → 0.5

* nuxt: `__NUXT__` → 0.5

* sveltekit: `__sveltekit` → 0.5

* gatsby: `___gatsby` → 0.5

* remix: `__remixContext` → 0.5

left a suggestion on that line to match the convention. otherwise lgtm 👍

Oops, sorry, missed that. Should be all good now.

@vmfunc vmfunc merged commit d9dd3dc into vmfunc:main Jan 6, 2026
7 checks passed
@0x4bs3nt 0x4bs3nt deleted the feat/astro-framework-detection branch January 12, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked waiting for changes by author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants