Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Commit f7736a4

Browse files
authored
Allow underscore in runtimes. Remove flaky test (#951)
1 parent bf2871f commit f7736a4

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

pkg/langruntime/langruntime.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ func (l *Langruntimes) getVersionFromRuntime(runtime string) string {
121121

122122
// GetRuntimeInfo returns all the info regarding a runtime
123123
func (l *Langruntimes) GetRuntimeInfo(runtime string) (RuntimeInfo, error) {
124-
runtimeID := regexp.MustCompile("^[a-zA-Z]+").FindString(runtime)
124+
runtimeID := regexp.MustCompile("^[a-zA-Z_-]+").FindString(runtime)
125125
for _, runtimeInf := range l.AvailableRuntimes {
126126
if runtimeInf.ID == runtimeID {
127127
return runtimeInf, nil

tests/integration-tests-cronjob.bats

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ load ../script/libtest
2525
verify_cronjob_trigger get-python '*/60 * * * *' '"GET / HTTP/1.1" 200 11 "" "curl/7.56.1"'
2626
delete_cronjob_trigger get-python
2727
verify_clean_object cronjobtrigger get-python
28-
verify_clean_object cronjob get-python
2928
}
3029

3130
@test "Test no-errors" {

0 commit comments

Comments
 (0)