Skip to content
This repository was archived by the owner on Jul 17, 2025. It is now read-only.

Commit c3dfd46

Browse files
committed
Remove debugging again.
1 parent b3fb7cb commit c3dfd46

File tree

4 files changed

+3
-13
lines changed

4 files changed

+3
-13
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ members = [
1616
"lib/rpc",
1717
"usr/init",
1818
"usr/rkapps",
19+
#"lib/fallible_collections",
1920
#"lib/libfringe",
2021
#"lib/acpica-sys"
2122
#"lib/rust-topology",

kernel/src/arch/x86_64/process.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -960,7 +960,6 @@ impl elfloader::ElfLoader for Ring3Process {
960960
.expect("Refill didn't work");
961961

962962
let pcm = crate::arch::kcb::per_core_mem();
963-
info!("1");
964963

965964
// TODO(correctness): Will this work (we round-up and map large-pages?)
966965
// TODO(efficiency): What about wasted memory
@@ -992,22 +991,19 @@ impl elfloader::ElfLoader for Ring3Process {
992991
.allocate_large_page()
993992
.expect("We refilled so allocation should work.")
994993
};
995-
info!("2");
996994

997995
trace!(
998996
"process load vspace from {:#x} with {:?}",
999997
self.offset + page_base + i * LARGE_PAGE_SIZE,
1000998
frame
1001999
);
1002-
info!("3");
10031000
self.vspace
10041001
.map_frame(
10051002
self.offset + page_base + i * LARGE_PAGE_SIZE,
10061003
frame,
10071004
map_action,
10081005
)
10091006
.expect("Can't map ELF region");
1010-
info!("4");
10111007
}
10121008
}
10131009

kernel/src/arch/x86_64/vspace/mod.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use fallible_collections::btree::BTreeMap;
88
use lazy_static::lazy_static;
99
use spin::Mutex;
1010
use x86::current::paging::{PDFlags, PDPTFlags, PTFlags};
11-
use log::info;
1211

1312
mod debug;
1413
pub mod page_table; /* TODO(encapsulation): This should be a private module but we break encapsulation in a few places */
@@ -91,7 +90,6 @@ pub(crate) struct VSpace {
9190

9291
impl AddressSpace for VSpace {
9392
fn map_frame(&mut self, base: VAddr, frame: Frame, action: MapAction) -> Result<(), KError> {
94-
info!("map_frame 1");
9593
if frame.size() == 0 {
9694
return Err(KError::InvalidFrame);
9795
}
@@ -103,7 +101,6 @@ impl AddressSpace for VSpace {
103101
// virtual addr should be aligned to page-size
104102
return Err(KError::InvalidBase);
105103
}
106-
info!("map_frame 2");
107104

108105
let tomap_range = base.as_usize()..base.as_usize() + frame.size;
109106

@@ -114,13 +111,11 @@ impl AddressSpace for VSpace {
114111
.range((Unbounded, Excluded(VAddr::from(tomap_range.end))))
115112
.rev()
116113
{
117-
info!("map_frame 3");
118114
let existing_map_range = existing_mapping.vrange(existing_base);
119115
if existing_map_range.end <= tomap_range.start {
120116
// We reached the end of relevant mappings
121117
break;
122118
}
123-
info!("map_frame 4");
124119

125120
if existing_base == base
126121
&& existing_mapping.frame.base == frame.base
@@ -134,12 +129,10 @@ impl AddressSpace for VSpace {
134129
});
135130
}
136131
}
137-
info!("map_frame 5");
132+
138133
self.mappings
139134
.try_insert(base, MappingInfo::new(frame, action))?;
140-
info!("map_frame 6");
141135
let r = self.page_table.map_frame(base, frame, action);
142-
info!("map_frame 6");
143136
r
144137
}
145138

0 commit comments

Comments
 (0)