Skip to content
This repository was archived by the owner on Oct 15, 2018. It is now read-only.

Script fails to exit when a file download fails and produces a bad environment #32

@TrevorKarjanis

Description

@TrevorKarjanis

Line 227 in dev_env.ps1 failed to download SetupTools and line 178 in dev_env_salt.ps1 of DownloadFileWithProgress doesn't check $Event (AsyncCompletedEventArgs) for an error. This resulted in a cascade of failed installations that require SetupTools and produced a bad environment. Should DownloadFileWithProgress check for failure and throw? Should the script throw if pip and easy_install processes exit with a failure? At the least, it should log download errors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions