Check for tx.Error on every operation on Tx (#31)

- Check for tx.Error before calling tx.Commit()
- Call defer tx.Rollback() which is no-op if tx.Commit()
succeeds, the tx will not be rolled back
- Fix all tests to use independent dbs to avoid conflicts
- Update gomarkdoc version to enable links for pkg references
- Update golang to 1.19 version and pin it in github workflow

Author: krishnamiriyala

.github/workflows/daily.yml

@@ -2,24 +2,30 @@
 name: Daily
 on:
   schedule:
-  - cron: "0 6 * * *"
+    - cron: "0 6 * * *"
+  workflow_dispatch:
+    inputs:
+      logLevel:
+        description: 'Log level'
+        required: true
+        default: 'trace'
 
 jobs:
   test:
     name: Unit test
     runs-on: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v3
-      - name: Set up Go using version from go.mod
-        uses: actions/setup-go@v3
+      - name: Set up Go using version for latest 1.19 version
+        uses: actions/setup-go@v4
         with:
-          go-version-file: 'go.mod'
-
+          go-version: '1.19'
+          check-latest: true
       - name: Run unit tests
         run: |
           mkdir -p $(go env GOPATH)
           mkdir -p $(go env GOCACHE)
-          sudo make test
+          sudo make test benchmarks
       - name: Codecov
         uses: codecov/codecov-action@v3
         with:
@@ -33,10 +39,11 @@ jobs:
     runs-on: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v3
-      - name: Set up Go using version from go.mod
-        uses: actions/setup-go@v3
+      - name: Set up Go using version for latest 1.19 version
+        uses: actions/setup-go@v4
         with:
-          go-version-file: 'go.mod'
+          go-version: '1.19'
+          check-latest: true
       - name: Run lint
         run: |
           mkdir -p $(go env GOPATH)

.github/workflows/go.yml

@@ -15,17 +15,24 @@ on:
     workflows: ["Build"]
     types:
       - complete
+  workflow_dispatch:
+    inputs:
+      logLevel:
+        description: 'Log level'
+        required: true
+        default: 'warning'
 
 jobs:
   test:
     name: Unit test
     runs-on: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v3
-      - name: Set up Go using version from go.mod
-        uses: actions/setup-go@v3
+      - name: Set up Go using version for latest 1.19 version
+        uses: actions/setup-go@v4
         with:
-          go-version-file: 'go.mod'
+          go-version: '1.19'
+          check-latest: true
 
       - name: Run unit tests
         run: |
@@ -45,10 +52,11 @@ jobs:
     runs-on: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v3
-      - name: Set up Go using version from go.mod
-        uses: actions/setup-go@v3
+      - name: Set up Go using version for latest 1.19 version
+        uses: actions/setup-go@v4
         with:
-          go-version-file: 'go.mod'
+          go-version: '1.19'
+          check-latest: true
       - name: Run lint
         run: |
           mkdir -p $(go env GOPATH)

build/install_tools.sh

@@ -4,7 +4,7 @@ set -eux
 source $(dirname "$0")/env.sh
 
 GOLNT_VERSION=v1.50.1
-GOMRK_VERSION=v0.4.1
+GOMRK_VERSION=v0.4.2-0.20230402163522-cc78abbcb570
 SHFMT_VERSION=v3.6.0
 TYPOS_VERSION=1.13.6