From 527d58b97efd0c1415600332ce4b3a96d1509f8c Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 9 Oct 2022 00:55:55 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- process_snapshot_toolkit/snapshot/utils.py | 24 +++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/process_snapshot_toolkit/snapshot/utils.py b/process_snapshot_toolkit/snapshot/utils.py index 0e42132..d4c6d3e 100755 --- a/process_snapshot_toolkit/snapshot/utils.py +++ b/process_snapshot_toolkit/snapshot/utils.py @@ -29,7 +29,29 @@ def extract_tar_archive(archive_path, output_dir): :return: output directory """ with tarfile.open(archive_path) as tar: - tar.extractall(output_dir) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, output_dir) return output_dir