fix vsc backup plugin progress method to not fail on temporary errors

shubham-pampattiwar · shubham-pampattiwar · commit 0743c4c2ec3b · 2024-01-24T23:06:44.000-08:00
diff --git a/internal/backup/volumesnapshotcontent_action.go b/internal/backup/volumesnapshotcontent_action.go
@@ -153,10 +153,11 @@ func (p *VolumeSnapshotContentBackupItemAction) Progress(operationID string, bac
 	if boolptr.IsSetToTrue(vsc.Status.ReadyToUse) {
 		progress.Completed = true
 	} else if vsc.Status.Error != nil {
-		progress.Completed = true
+		errorMessage := ""
 		if vsc.Status.Error.Message != nil {
-			progress.Err = *vsc.Status.Error.Message
+			errorMessage = *vsc.Status.Error.Message
 		}
+		p.Log.Warnf("VolumeSnapshotContent has a temporary error %s. SnapshotContent controller will retry later.", errorMessage)
 	}
 
 	return progress, nil

Original file line number	Diff line number	Diff line change
`@@ -153,10 +153,11 @@ func (p *VolumeSnapshotContentBackupItemAction) Progress(operationID string, bac`
`153`	`153`	`if boolptr.IsSetToTrue(vsc.Status.ReadyToUse) {`
`154`	`154`	`progress.Completed = true`
`155`	`155`	`} else if vsc.Status.Error != nil {`
`156`		`- progress.Completed = true`
	`156`	`+ errorMessage := ""`
`157`	`157`	`if vsc.Status.Error.Message != nil {`
`158`		`- progress.Err = *vsc.Status.Error.Message`
	`158`	`+ errorMessage = *vsc.Status.Error.Message`
`159`	`159`	`}`
	`160`	`+ p.Log.Warnf("VolumeSnapshotContent has a temporary error %s. SnapshotContent controller will retry later.", errorMessage)`
`160`	`161`	`}`
`161`	`162`
`162`	`163`	`return progress, nil`