-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Description
Describe the problem/challenge you have
After #9255, the GLOB regex is already supported in backup and restore's namespace filter.
However, only the asterisk characters can pass the backup and restore namespace filter validation check.
The other characters cannot.
For example, velero backup create --include-namespaces="glob-ns-[12]" glob-test-2
this CLI failed with error: An error occurred: invalid namespace "glob-ns-[12]": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
Describe the solution you'd like
Since the GLOB regex is already supported, the validation check should allow all GLOB wildcard characters.
https://github.com/vmware-tanzu/velero/pull/9255/files#diff-2373abcf6c2cdf9662f5358642b0443fe8bede7a3acd3dc76b7a7eb15e91b265
Anything else you would like to add:
Environment:
- Velero version (use
velero version): - Kubernetes version (use
kubectl version): - Kubernetes installer & version:
- Cloud provider or hardware configuration:
- OS (e.g. from
/etc/os-release):
Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
- 👍 for "The project would be better with this feature added"
- 👎 for "This feature will not enhance the project in a meaningful way"