Merge pull request #1202 from vmware/fix-sp-crash

Fix a crash in security policy

Author: annakhm

nsxt/resource_nsxt_policy_parent_security_policy.go

@@ -65,7 +65,7 @@ func parentSecurityPolicyModelToSchema(d *schema.ResourceData, m interface{}) (*
 	client := domains.NewSecurityPoliciesClient(getSessionContext(d, m), connector)
 	obj, err := client.Get(domainName, id)
 	if err != nil {
-		return nil, handleReadError(d, "SecurityPolicy", id, err)
+		return nil, err
 	}
 	d.Set("display_name", obj.DisplayName)
 	d.Set("description", obj.Description)

nsxt/resource_nsxt_policy_security_policy.go

@@ -137,7 +137,7 @@ func resourceNsxtPolicySecurityPolicyGeneralCreate(d *schema.ResourceData, m int
 func resourceNsxtPolicySecurityPolicyGeneralRead(d *schema.ResourceData, m interface{}, withRule bool) error {
 	obj, err := parentSecurityPolicyModelToSchema(d, m)
 	if err != nil {
-		return err
+		return handleReadError(d, "SecurityPolicy", d.Id(), err)
 	}
 	if withRule {
 		return setPolicyRulesInSchema(d, obj.Rules)