Revert some workflow changes

Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>

Author: ksamoray

.github/workflows/golangci-lint.yml

@@ -1,13 +1,12 @@
----
 name: golangci-lint
 
 on:
   pull_request:
     paths-ignore:
-      - README.md
+      - 'README.md'
   push:
     paths-ignore:
-      - README.md
+      - 'README.md'
 
 permissions:
   contents: read
@@ -16,19 +15,20 @@ jobs:
   build:
     name: Build
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
       - name: Checkout
         uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
       - name: Setup Go
         uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version-file: go.mod
+          go-version-file: 'go.mod'
           cache: false
       - run: go mod download
       - run: go build -v .
       - name: Run Linters
-        uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
+        uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
         with:
-          version: latest
+          version: v1.64.8
           args: --issues-exit-code=1 --timeout 10m
           only-new-issues: true

.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
         with:
-          version: v1.61
+          version: v1.64.8
           args: --issues-exit-code=1 --timeout=30m
           skip-pkg-cache: true
           skip-build-cache: true

.golangci.yml

@@ -1,84 +1,52 @@
----
-version: "2"
+# © Broadcom. All Rights Reserved.
+# The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.
+# SPDX-License-Identifier: MPL-2.0
 
-output:
-  formats:
-    text:
-      path: stdout
+# For more information about the golangci-lint configuration file, refer to:
+# https://golangci-lint.run/usage/configuration/
+
+issues:
+  exclude-rules:
+    # Exclude specific staticcheck rules to suppress false positives or acceptable issues.
+    - linters: [staticcheck]
+      text: "SA4004|SA1019|GetOkExists"
+    # Exclude specific gosec rules to suppress warnings about issues deemed acceptable.
+    - linters: [gosec]
+      text: "G402|G404|G115"
 
 linters:
-  default: none
+  disable-all: true # Disable all linters by default and enable only the ones required.
   enable:
-    - gosec             # Checks for security issues in code.
+    - gofmt             # Checks Go code formatting.
+    - goimports         # Ensures proper import formatting.
+    - gosimple          # Reports simplifications in code.
     - govet             # Examines code for possible mistakes.
+    - gosec             # Checks for security issues in code.
     - ineffassign       # Detects inefficient assignments.
     - misspell          # Finds and fixes typos.
     - staticcheck       # Reports bugs, code smells, and deprecated practices.
-    - unused            # Detects unused variables, constants, etc.
-  settings:
-    errcheck:
-      exclude-functions:
-        - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set
-        - fmt:.*
-        - io:Close
-    revive:
-      rules:
-        - name: unreachable-code      # Detect code that will never be executed.
-        - name: errorf                # Avoid string formatting in error messages.
-        - name: range                 # Improve range loop usage.
-        - name: superfluous-else       # Eliminate unnecessary else statements.
-        - name: var-declaration       # Simplify variable declaration.
-        - name: duplicated-imports    # Detect and remove duplicate imports.-imports
-  exclusions:
-    generated: lax
-    presets:
-      - comments
-      - common-false-positives
-      - legacy
-      - std-error-handling
-    rules:
-      # Exclude specific staticcheck rules to suppress false positives or acceptable issues.
-      - linters:
-          - staticcheck
-        text: SA4004|SA1019|GetOkExists
-      # Exclude specific gosec rules to suppress warnings about issues deemed acceptable.
-      - linters:
-          - gosec
-        text: G402|G404|G115
-      # TODO: Setting temporary exclusions.
-      - linters:
-          - staticcheck
-        text: QF1001
-      - linters:
-          - staticcheck
-        text: QF1003
-      - linters:
-          - staticcheck
-        text: QF1004
-      - linters:
-          - staticcheck
-        text: QF1007
-      - linters:
-          - staticcheck
-        text: QF1011
-      - linters:
-          - staticcheck
-        text: ST1005
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
 
 run:
   timeout: 30m # Sets the maximum time limit for the linter run.
 
-formatters:
-  enable:
-    - gofmt
-    - goimports
-  exclusions:
-    generated: lax
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
+output:
+  formats:
+    - format: colored-line-number # Allows colored output with line numbers when errors are reported.
+
+linters-settings:
+  errcheck:
+    # Exclude specific functions from errcheck warnings, as errors are intentionally ignored in these cases.
+    exclude-functions:
+      - "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set"
+      - "fmt:.*"
+      - "io:Close"
+
+  revive:
+    # Enable specific rules for the revive linter for improved code quality and readability.
+    rules:
+      - name: unreachable-code      # Detect code that will never be executed.
+      - name: errorf                # Avoid string formatting in error messages.
+      - name: range                 # Improve range loop usage.
+      - name: superfluous-else      # Eliminate unnecessary else statements.
+      - name: var-declaration       # Simplify variable declaration.
+      - name: duplicated-imports    # Detect and remove duplicate imports.-imports

.goreleaser.yml

@@ -1,20 +1,25 @@
----
-version: 2
-
-project_name: terraform-provider-nsxt
-
+# Visit https://goreleaser.com for documentation on how to customize this
+# behavior.
 before:
   hooks:
+    # this is just an example and not a requirement for provider building/publishing
     - go mod tidy
-
 builds:
-  - id: default
-    binary: '{{ .ProjectName }}_v{{ .Version }}'
+  - env:
+      # goreleaser does not work with CGO, it could also complicate
+      # usage by users in CI/CD systems like Terraform Cloud where
+      # they are unable to install libraries.
+      - CGO_ENABLED=0
+    mod_timestamp: '{{ .CommitTimestamp }}'
+    flags:
+      - -trimpath
+    ldflags:
+      - '-s -w -X main.version={{.Version}} -X main.commit={{.Commit}}'
     goos:
-      - linux
+      - freebsd
       - windows
+      - linux
       - darwin
-      - freebsd
     goarch:
       - amd64
       - '386'
@@ -23,44 +28,28 @@ builds:
     ignore:
       - goos: darwin
         goarch: '386'
-    env:
-      - CGO_ENABLED=0
-    flags:
-      - -trimpath
-    ldflags:
-      - '-s -w -X main.version={{.Version}} -X main.commit={{.Commit}}'
-    mod_timestamp: '{{ .CommitTimestamp }}'
-
+    binary: '{{ .ProjectName }}_v{{ .Version }}'
 archives:
-  - id: default
+  - format: zip
     name_template: '{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}'
-    formats: ['zip']
-
 checksum:
   name_template: '{{ .ProjectName }}_{{ .Version }}_SHA256SUMS'
   algorithm: sha256
-  extra_files:
-    - glob: 'terraform-registry-manifest.json'
-      name_template: '{{ .ProjectName }}_{{ .Version }}_manifest.json'
-
 signs:
-  - id: default
-    artifacts: checksum
+  - artifacts: checksum
     args:
+      # if you are using this is a GitHub action or some other automated pipeline, you
+      # need to pass the batch flag to indicate its not interactive.
       - "--batch"
       - "--local-user"
-      - "{{ .Env.GPG_FINGERPRINT }}"
+      - "{{ .Env.GPG_FINGERPRINT }}" # set this environment variable for your signing key
       - "--output"
       - "${signature}"
       - "--detach-sign"
       - "${artifact}"
-
 release:
+  # Visit your project's GitHub Releases page to publish this release.
   draft: true
-  extra_files:
-    - glob: 'terraform-registry-manifest.json'
-      name_template: '{{ .ProjectName }}_{{ .Version }}_manifest.json'
-
 changelog:
   filters:
     exclude: