chore: bump golangci-lint and handle gosec warnings

Signed-off-by: Stoyan Zhelyazkov <stoyan.zhelyazkov@broadcom.com>

Author: spacegospod

.github/workflows/golangci-lint.yml

@@ -43,4 +43,4 @@ jobs:
       - name: Run Linters
         uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
         with:
-          version: v2.1.6
+          version: v2.11.3

vsphere/c19e68b4cb68e0d0e2006f74f0ea94cfd269a892b77d2253b1d162873229ad35

@@ -0,0 +1 @@
+{"SoapClient":{"cookies":[{"Name":"vmware_soap_session","Value":"ba9614f77acbffc2c44832633fc81ba764ca3e2a","Quoted":true,"Path":"","Domain":"","Expires":"0001-01-01T00:00:00Z","RawExpires":"","MaxAge":0,"Secure":false,"HttpOnly":false,"SameSite":0,"Partitioned":false,"Raw":"","Unparsed":null}],"url":{"Scheme":"https","Opaque":"","User":null,"Host":"10.167.17.3","Path":"/sdk","RawPath":"","OmitHost":false,"ForceQuery":false,"RawQuery":"","Fragment":"","RawFragment":""},"insecure":true,"version":"9.1.0.0","useJSON":false},"ServiceContent":{"rootFolder":{"type":"Folder","value":"group-d1"},"propertyCollector":{"type":"PropertyCollector","value":"propertyCollector"},"viewManager":{"type":"ViewManager","value":"ViewManager"},"about":{"name":"VMware vCenter Server","fullName":"VMware vCenter Server 9.1.0.0.25234335","vendor":"VMware, Inc.","version":"9.1.0","patchLevel":"0","build":"25234335","localeVersion":"INTL","localeBuild":"000","osType":"linux-x64","productLineId":"vpx","apiType":"VirtualCenter","apiVersion":"9.1.0.0","instanceUuid":"82e01dff-8487-4a3e-ad9b-4c9b5a875251","licenseProductName":"VMware VirtualCenter Server","licenseProductVersion":"9.1"},"setting":{"type":"OptionManager","value":"VpxSettings"},"userDirectory":{"type":"UserDirectory","value":"UserDirectory"},"sessionManager":{"type":"SessionManager","value":"SessionManager"},"authorizationManager":{"type":"AuthorizationManager","value":"AuthorizationManager"},"serviceManager":{"type":"ServiceManager","value":"ServiceMgr"},"perfManager":{"type":"PerformanceManager","value":"PerfMgr"},"scheduledTaskManager":{"type":"ScheduledTaskManager","value":"ScheduledTaskManager"},"alarmManager":{"type":"AlarmManager","value":"AlarmManager"},"eventManager":{"type":"EventManager","value":"EventManager"},"taskManager":{"type":"TaskManager","value":"TaskManager"},"extensionManager":{"type":"ExtensionManager","value":"ExtensionManager"},"customizationSpecManager":{"type":"CustomizationSpecManager","value":"CustomizationSpecManager"},"guestCustomizationManager":{"type":"VirtualMachineGuestCustomizationManager","value":"GuestCustomizationManager"},"customFieldsManager":{"type":"CustomFieldsManager","value":"CustomFieldsManager"},"diagnosticManager":{"type":"DiagnosticManager","value":"DiagMgr"},"licenseManager":{"type":"LicenseManager","value":"LicenseManager"},"searchIndex":{"type":"SearchIndex","value":"SearchIndex"},"fileManager":{"type":"FileManager","value":"FileManager"},"datastoreNamespaceManager":{"type":"DatastoreNamespaceManager","value":"DatastoreNamespaceManager"},"virtualDiskManager":{"type":"VirtualDiskManager","value":"virtualDiskManager"},"snmpSystem":{"type":"HostSnmpSystem","value":"SnmpSystem"},"vmProvisioningChecker":{"type":"VirtualMachineProvisioningChecker","value":"ProvChecker"},"vmCompatibilityChecker":{"type":"VirtualMachineCompatibilityChecker","value":"CompatChecker"},"ovfManager":{"type":"OvfManager","value":"OvfManager"},"ipPoolManager":{"type":"IpPoolManager","value":"IpPoolManager"},"dvSwitchManager":{"type":"DistributedVirtualSwitchManager","value":"DVSManager"},"hostProfileManager":{"type":"HostProfileManager","value":"HostProfileManager"},"clusterProfileManager":{"type":"ClusterProfileManager","value":"ClusterProfileManager"},"complianceManager":{"type":"ProfileComplianceManager","value":"MoComplianceManager"},"localizationManager":{"type":"LocalizationManager","value":"LocalizationManager"},"storageResourceManager":{"type":"StorageResourceManager","value":"StorageResourceManager"},"guestOperationsManager":{"type":"GuestOperationsManager","value":"guestOperationsManager"},"overheadMemoryManager":{"type":"OverheadMemoryManager","value":"OverheadMemoryManager"},"certificateManager":{"type":"CertificateManager","value":"certificateManager"},"ioFilterManager":{"type":"IoFilterManager","value":"IoFilterManager"},"vStorageObjectManager":{"type":"VcenterVStorageObjectManager","value":"VStorageObjectManager"},"hostSpecManager":{"type":"HostSpecificationManager","value":"HostSpecificationManager"},"cryptoManager":{"type":"CryptoManagerKmip","value":"CryptoManager"},"healthUpdateManager":{"type":"HealthUpdateManager","value":"HealthUpdateManager"},"failoverClusterConfigurator":{"type":"FailoverClusterConfigurator","value":"FailoverClusterConfigurator"},"failoverClusterManager":{"type":"FailoverClusterManager","value":"FailoverClusterManager"},"tenantManager":{"type":"TenantTenantManager","value":"TenantManager-25234335"},"siteInfoManager":{"type":"SiteInfoManager","value":"SiteInfoManager"},"storageQueryManager":{"type":"StorageQueryManager","value":"StorageQueryManager"},"directPathProfileManager":{"type":"DirectPathProfileManager","value":"DirectPathProfileMgr"}}}

vsphere/config.go

@@ -284,10 +284,10 @@ func (c *Config) EnableDebug() error {
 	} else {
 		// reuse the same path
 		r = filepath.Join(r, run)
-		_ = os.RemoveAll(r)
+		_ = os.RemoveAll(r) // nolint (gosec G703)
 	}
 
-	err := os.MkdirAll(r, 0700)
+	err := os.MkdirAll(r, 0700) // nolint (gosec G703)
 	if err != nil {
 		log.Printf("[ERROR] Client debug setup failed: %v", err)
 		return err

vsphere/resource_vsphere_host_test.go

@@ -827,6 +827,5 @@ resource "vsphere_host" "h1" {
 		os.Getenv("ESX_USERNAME"),
 		os.Getenv("ESX_PASSWORD"),
 		serversStr)
-	log.Printf("Generated Terraform configuration: %s", config)
 	return config
 }