fix(react-providers): regression in isAbleToVote

Author: elboletaire

packages/react-providers/src/election/ElectionProvider.test.tsx

@@ -660,6 +660,55 @@ describe('<ElectionProvider />', () => {
     localStorage.removeItem('csp_token')
   })
 
+  it('enables voting when CSP token is set after initial render and sign-info returns 401', async () => {
+    jest.mocked(fetchSignInfo).mockRejectedValueOnce({ status: 401 })
+
+    const client = new VocdoniSDKClient({
+      env: EnvOptions.STG,
+    })
+
+    const census = new WeightedCensus()
+    census.type = CensusType.CSP
+    census.censusURI = 'https://csp.example/api'
+
+    // @ts-ignore
+    const election = PublishedElection.build({
+      id: 'csp-election-late-token',
+      title: 'test',
+      description: 'test',
+      endDate: new Date(),
+      census,
+      electionType: { anonymous: false },
+      voteType: { maxVoteOverwrites: 0, maxCount: 1, maxValue: 1 },
+    })
+
+    const wrapper = (props: any) => {
+      return (
+        <TestProvider>
+          <ClientProvider {...onlyProps(props)}>
+            <ElectionProvider {...properProps(props)} />
+          </ClientProvider>
+        </TestProvider>
+      )
+    }
+
+    const { result } = renderHook(() => useElection(), {
+      wrapper,
+      initialProps: { election, fetchCensus: true, client },
+    })
+
+    await act(async () => {
+      result.current.actions.csp1('token')
+    })
+
+    await waitFor(() => {
+      expect(result.current.votesLeft).toBe(1)
+    })
+
+    expect(result.current.isInCensus).toBeTruthy()
+    expect(result.current.isAbleToVote).toBeTruthy()
+  })
+
   it('treats 401 on CSP sign info as no prior vote', async () => {
     localStorage.setItem('csp_token', 'token')
     jest.mocked(fetchSignInfo).mockRejectedValueOnce({ status: 401 })

packages/react-providers/src/election/use-election-provider.ts

@@ -264,7 +264,18 @@ export const useElectionProvider = ({
       await censusFetch()
     })()
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [fetchCensus, client, state.voter, loaded.election, loading.census, actions, state.isAbleToVote, signature])
+  }, [
+    fetchCensus,
+    client,
+    client.wallet,
+    state.voter,
+    loaded.election,
+    loading.census,
+    actions,
+    state.isAbleToVote,
+    signature,
+    state.csp.token,
+  ])
 
   // csp check sign info (check if voter already voted)
   useEffect(() => {

packages/react-providers/src/election/use-election-reducer.ts

@@ -220,13 +220,17 @@ const electionReducer: Reducer<ElectionReducerState, ElectionAction> = (
     case ElectionCspStep1: {
       const token = action.payload as ElectionCspStep1Payload
       localStorage.setItem(LSKey.tokenR, token)
-      return {
+      const rstate = {
         ...state,
         csp: {
           ...state.csp,
           token,
         },
       }
+      return {
+        ...rstate,
+        isAbleToVote: isAbleToVote(rstate),
+      }
     }
 
     case ElectionLoad:
@@ -248,10 +252,14 @@ const electionReducer: Reducer<ElectionReducerState, ElectionAction> = (
 
     case ElectionInCensus: {
       const isInCensus = action.payload as ElectionInCensusPayload
-      return {
+      const rstate = {
         ...state,
         isInCensus,
       }
+      return {
+        ...rstate,
+        isAbleToVote: isAbleToVote(rstate),
+      }
     }
 
     case ElectionVoted: {
@@ -290,10 +298,14 @@ const electionReducer: Reducer<ElectionReducerState, ElectionAction> = (
 
     case ElectionVotesLeft: {
       const votesLeft = action.payload as ElectionVotesLeftPayload
-      return {
+      const rstate = {
         ...state,
         votesLeft,
       }
+      return {
+        ...rstate,
+        isAbleToVote: isAbleToVote(rstate),
+      }
     }
 
     case ElectionClientSet: {