Skip to content

Commit 2593f17

Browse files
vogellaclaude
andcommitted
Fix JUnit 5 migration issues in org.eclipse.text.tests
This commit fixes test failures introduced during the JUnit 5 migration in PR eclipse-platform#3410 for the org.eclipse.text.tests bundle. Changes: 1. Added missing JUnit 5 package import to MANIFEST.MF: - org.junit.jupiter.api.function (required for assertThrows) 2. Fixed assertEquals parameter order in TextEditTests.java: - JUnit 5 changed assertEquals signature from (message, expected, actual) to (expected, actual, message) - Fixed 61 assertions to use correct JUnit 5 parameter order 3. Fixed annotation in FindReplaceDocumentAdapterTest.java: - Changed @org.junit.Test (JUnit 4) to @test (JUnit 5) - This was preventing @beforeeach from running, causing null pointer errors All 578 tests now pass successfully (0 failures, 0 errors, 2 skipped). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 75794ca commit 2593f17

File tree

3 files changed

+47
-46
lines changed

3 files changed

+47
-46
lines changed

tests/org.eclipse.text.tests/META-INF/MANIFEST.MF

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Require-Bundle:
1515
org.eclipse.text;bundle-version="[3.6.3,4.0.0)",
1616
org.junit;bundle-version="4.12.0"
1717
Import-Package: org.junit.jupiter.api;version="[5.14.0,6.0.0)",
18+
org.junit.jupiter.api.function;version="[5.14.0,6.0.0)",
1819
org.junit.platform.suite.api;version="[1.14.0,2.0.0)"
1920
Bundle-RequiredExecutionEnvironment: JavaSE-17
2021
Eclipse-BundleShape: dir

tests/org.eclipse.text.tests/src/org/eclipse/text/tests/FindReplaceDocumentAdapterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void tearDown () {
7777
fDocument= null;
7878
}
7979

80-
@org.junit.Test
80+
@Test
8181
public void testFind() {
8282
FindReplaceDocumentAdapter findReplaceDocumentAdapter= new FindReplaceDocumentAdapter(fDocument);
8383
try {

0 commit comments

Comments
 (0)