fix: remove Bluebird (VF-000) (#67)

**Fixes or implements VF-000**

### Brief description. What is this change?

refactors the responsebuilder to not use bluebird

this should stop the endless stream of warnings bluebird would produce

![screenshot of warning messages in the logs](https://user-images.githubusercontent.com/7608555/153926817-095dc54d-aad3-41dd-a332-cccccbc45ea6.png)

### Checklist

- [ ] this is a breaking change and should publish a new major version
- [ ] appropriate tests have been written

Author: jonahsnider

package.json

@@ -12,7 +12,6 @@
     }
   },
   "dependencies": {
-    "@types/bluebird": "^3.5.33",
     "@types/chai": "^4.2.16",
     "@types/express": "^4.17.11",
     "@types/ioredis": "^4.26.4",
@@ -21,7 +20,6 @@
     "@types/sinon": "^10.0.0",
     "@voiceflow/logger": "1.6.1",
     "@voiceflow/verror": "^1.1.0",
-    "bluebird": "^3.7.2",
     "chai": "^4.3.4",
     "dotenv": "^10.0.0",
     "express": "^4.17.1",

src/responseBuilder.ts

@@ -1,6 +1,5 @@
 import VError from '@voiceflow/verror';
 import type { AxiosError } from 'axios';
-import Promise from 'bluebird';
 import { NextFunction, Request, Response } from 'express';
 import * as ExpressValidator from 'express-validator';
 import { HttpStatus } from 'http-status';
@@ -196,27 +195,27 @@ class ResponseBuilder {
         nextCalled = () => next(route);
       };
 
-      await Promise.try(() => (typeof dataPromise === 'function' ? (dataPromise as any)(req, res, nextCheck) : dataPromise))
-        .then((data) => {
-          if (data instanceof Error) {
-            return ResponseBuilder.errorResponse(data, failureCodeOverride, req);
-          }
-
-          return ResponseBuilder.okResponse(data, successCodeOverride);
-        })
-        .catch((err) => ResponseBuilder.errorResponse(err, failureCodeOverride, req))
-        .then((output) => {
-          if (res.headersSent) {
-            return;
-          }
-
-          // eslint-disable-next-line promise/always-return
-          if (nextCalled) {
-            nextCalled();
-            return;
-          }
+      let output: ErrorResponse<unknown> | ReturnType<typeof ResponseBuilder['okResponse']>;
+
+      try {
+        const data = await (typeof dataPromise === 'function' ? (dataPromise as any)(req, res, nextCheck) : dataPromise);
+
+        output =
+          data instanceof Error
+            ? ResponseBuilder.errorResponse(data, failureCodeOverride, req)
+            : ResponseBuilder.okResponse(data, successCodeOverride);
+      } catch (err) {
+        output = ResponseBuilder.errorResponse(err, failureCodeOverride, req);
+      }
+
+      if (!res.headersSent) {
+        if (nextCalled) {
+          // TypeScript doesn't know that calling nextCheck will define nextCalled as a function
+          (nextCalled as () => void)();
+        } else {
           res.status(output.code as number).json(output.data);
-        });
+        }
+      }
     }) as any;
   }
   /* eslint-enable no-param-reassign */

yarn.lock

@@ -809,11 +809,6 @@
   dependencies:
     axios "*"
 
-"@types/bluebird@^3.5.33":
-  version "3.5.33"
-  resolved "https://registry.yarnpkg.com/@types/bluebird/-/bluebird-3.5.33.tgz#d79c020f283bd50bd76101d7d300313c107325fc"
-  integrity sha512-ndEo1xvnYeHxm7I/5sF6tBvnsA4Tdi3zj1keRKRs12SP+2ye2A27NDJ1B6PqkfMbGAcT+mqQVqbZRIrhfOp5PQ==
-
 "@types/body-parser@*":
   version "1.19.0"
   resolved "https://registry.yarnpkg.com/@types/body-parser/-/body-parser-1.19.0.tgz#0685b3c47eb3006ffed117cdd55164b61f80538f"