Skip to content

Commit 3b4cdb5

Browse files
committed
feat: upgrade logger, move to peer dep (PL-000) (#114)
Migration path: - Upgrade to `@voiceflow/[email protected]`, with new instantiation. - Remove exception middleware from express - Ensure `createHTTPLogger` is added to express BREAKING CHANGE: Move to `@voiceflow/logger` v2, as a peer dep. BREAKING CHANGE: Remove the exception middleware, as this same functionality is done better by the `pino-http` logger in `@voiceflow/logger`. Co-authored-by: Tyler Stewart <[email protected]>
1 parent 81967c5 commit 3b4cdb5

File tree

13 files changed

+228
-459
lines changed

13 files changed

+228
-459
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
},
1414
"dependencies": {
1515
"@types/http-errors": "^1.8.2",
16-
"@voiceflow/logger": "1.6.1",
1716
"@voiceflow/verror": "1.1.3",
1817
"chai": "^4.3.4",
1918
"dotenv": "^10.0.0",
@@ -45,6 +44,7 @@
4544
"@voiceflow/common": "7.27.3",
4645
"@voiceflow/eslint-config": "6.1.0",
4746
"@voiceflow/git-branch-check": "1.4.0",
47+
"@voiceflow/logger": "2.2.0",
4848
"@voiceflow/prettier-config": "1.2.1",
4949
"@voiceflow/tsconfig": "1.4.3",
5050
"chai-as-promised": "^7.1.1",
@@ -81,6 +81,7 @@
8181
"@types/express": "^4.17.13",
8282
"@types/ioredis": "^4.28.10",
8383
"@voiceflow/common": "^7.2.0",
84+
"@voiceflow/logger": "^2",
8485
"express-validator": "^6.3.0",
8586
"ioredis": "^4.28.5",
8687
"jszip": "^3.7.1"

src/logger.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import Logger from '@voiceflow/logger';
1+
import { createLogger, LogFormat, LogLevel } from '@voiceflow/logger';
22

3-
const options = ['local', 'test'].includes(process.env.NODE_ENV!) ? { level: 'info' as any, pretty: true } : {};
4-
5-
const log = new Logger(options);
3+
const log = createLogger({
4+
format: LogFormat.INLINE,
5+
level: (process.env.LOG_LEVEL as LogLevel) ?? LogLevel.INFO,
6+
});
67

78
export default log;

src/middlewares/exception/formatters/gaxiosError.ts

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/middlewares/exception/formatters/httpError.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/middlewares/exception/formatters/index.ts

Lines changed: 0 additions & 28 deletions
This file was deleted.

src/middlewares/exception/formatters/jsError.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/middlewares/exception/formatters/vError.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/middlewares/exception/index.ts

Lines changed: 0 additions & 32 deletions
This file was deleted.

src/middlewares/exception/types.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/middlewares/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
export * from './exception';
21
export * from './rateLimit';

0 commit comments

Comments
 (0)