ci(circleci): added sonar and git hooks (CORE-4768) (#16)

* ci(circleci): added sonar and git hooks

* fix: move pr check to circleci and eslint finished

Author: xavidop

.circleci/config.yml

@@ -2,7 +2,9 @@ version: 2.1
 
 orbs:
   codecov: codecov/[email protected]
-  vfcommon: voiceflow/[email protected]
+  vfcommon: voiceflow/[email protected]
+  sonarcloud: sonarsource/[email protected]
+  validate-title: qventus/[email protected]
 
 jobs:
   build-and-test:
@@ -11,6 +13,7 @@ jobs:
       - checkout
       - vfcommon/install_node_modules
       - vfcommon/lint_source
+      - vfcommon/lint_report
       - vfcommon/unit_tests
       - codecov/upload:
           file: nyc_coverage/lcov.info
@@ -19,8 +22,22 @@ jobs:
       - codecov/upload:
           file: nyc_coverage/lcov.info
           flags: integration
+      - sonarcloud/scan
 
 workflows:
+  pr-checker:
+    jobs:
+      - validate-title/validate:
+          context: dev-test
+          regex: >-
+            $PR_REGEX
+          filters:
+            branches:
+              ignore:
+                - /env-.*/
+                - staging
+                - master
+
   test-and-release:
     jobs:
       - build-and-test

.codecov.yml

@@ -13,5 +13,5 @@ coverage:
           - unit
           - integration
         paths:
-          - src
+          - lib
         only_pulls: true

.eslintrc.js

@@ -1,9 +1,5 @@
+'use strict';
+
 module.exports = {
   extends: '@voiceflow/eslint-config',
-  rules: {
-    'no-continue': 'off',
-    'quotes': ['error', 'single', 'avoid-escape'],
-    'sonarjs/cognitive-complexity': 'warn',
-    'promise/always-return': 'off',
-  }
 };

package.json

@@ -12,7 +12,7 @@
     }
   },
   "dependencies": {
-    "@voiceflow/logger": "^1.1.10",
+    "@voiceflow/logger": "^1.4.2",
     "@voiceflow/verror": "^1.1.0",
     "bluebird": "^3.7.2",
     "chai": "^4.2.0",
@@ -26,9 +26,9 @@
   },
   "devDependencies": {
     "@commitlint/config-conventional": "^8.0.0",
-    "@voiceflow/eslint-config": "^2.0.1",
-    "@voiceflow/git-branch-check": "^1.0.2",
-    "@voiceflow/prettier-config": "^1.0.4",
+    "@voiceflow/eslint-config": "^2.0.5",
+    "@voiceflow/git-branch-check": "^1.1.3",
+    "@voiceflow/prettier-config": "^1.0.5",
     "codacy-coverage": "^3.4.0",
     "commitizen": "^3.1.1",
     "commitlint": "^8.0.0",
@@ -41,7 +41,8 @@
     "lint-staged": "^8.2.1",
     "mocha": "^6.1.4",
     "nyc": "^14.1.0",
-    "prettier": "^1.18.2",
+    "prettier": "^1.19.1",
+    "prettier-eslint-cli": "^5.0.0",
     "semantic-release": "^15.13.17",
     "supertest": "^4.0.2"
   },
@@ -71,6 +72,7 @@
     ],
     "**/*.js": [
       "eslint --fix",
+      "prettier-eslint --write",
       "git add"
     ]
   },
@@ -85,10 +87,11 @@
     "lint": "eslint \"**/*.js\"",
     "lint:fix": "yarn lint --fix",
     "lint:quiet": "yarn lint --quiet",
+    "lint:report": "yarn lint --format json -o sonar/report.json",
     "prepare": "fixpack",
     "test": "nyc mocha --opts ./config/tests/mocha.opts 'tests/**/*.{unit,it}.js'",
-    "test:unit": "nyc mocha --opts ./config/tests/mocha.opts 'tests/**/*.unit.js'",
     "test:integration": "nyc mocha --opts ./config/tests/mocha.opts 'tests/**/*.it.js'",
-    "test:single": "mocha --opts ./config/tests/mocha.opts"
+    "test:single": "mocha --opts ./config/tests/mocha.opts",
+    "test:unit": "nyc mocha --opts ./config/tests/mocha.opts 'tests/**/*.unit.js'"
   }
 }

sonar-project.properties

@@ -0,0 +1,8 @@
+sonar.organization=voiceflow
+sonar.projectKey=voiceflow_backend-utils
+sonar.projectName=backend-utils
+sonar.sources=lib
+sonar.tests=tests
+sonar.eslint.reportPaths=sonar/report.json
+sonar.typescript.tsconfigPath=./tsconfig.json
+sonar.coverage.exclusions=**/**

tests/.eslintrc.js

@@ -1,13 +1,5 @@
+'use strict';
+
 module.exports = {
   extends: '../.eslintrc.js',
-  rules: {
-    'no-continue': 'off',
-    'quotes': ['error', 'single', 'avoid-escape'],
-    'sonarjs/cognitive-complexity': 'warn',
-    'promise/always-return': 'off',
-    'require-jsdoc': 'off',
-    'no-unused-expressions': 'off',
-    'sonarjs/no-duplicate-string': 'off',
-    'eslint-comments/disable-enable-pair': 'off'
-  }
 };