fix: import TextDecoder (VF-000) (#82)

* fix: import TextDecoder (VF-000)

* chore: update deps

* chore: fix tests

Author: trs

package.json

@@ -42,7 +42,7 @@
     "@types/supertest": "^2.0.11",
     "@voiceflow/commitlint-config": "2.0.0",
     "@voiceflow/common": "7.27.0",
-    "@voiceflow/eslint-config": "5.1.2",
+    "@voiceflow/eslint-config": "6.0.1",
     "@voiceflow/git-branch-check": "1.2.3",
     "@voiceflow/prettier-config": "1.0.7",
     "@voiceflow/tsconfig": "1.2.5",
@@ -54,7 +54,7 @@
     "eslint": "^7.32.0",
     "eslint-output": "^3.0.1",
     "express": "^4.17.3",
-    "express-validator": "^6.10.1",
+    "express-validator": "^6.3.0",
     "fixpack": "^4.0.0",
     "husky": "^4.3.8",
     "lint-staged": "12.2.2",

src/common/zip/reader.ts

@@ -1,6 +1,7 @@
 import { AnyRecord } from '@voiceflow/common';
 import JSZip from 'jszip';
 import minimatch from 'minimatch';
+import { TextDecoder } from 'util';
 
 import { isZipFile } from './guard';
 

tests/common/zip/reader.unit.ts

@@ -1,5 +1,6 @@
 import { expect } from 'chai';
 import JSZip from 'jszip';
+import { TextDecoder } from 'util';
 
 import { ZipReader } from '../../../src/common/zip';
 

tests/responseBuilder.unit.ts

@@ -31,7 +31,7 @@ describe('responseBuilder unit tests', () => {
   it('returns ok response with different code', async () => {
     const responseBuilder = new ResponseBuilder();
     const res = { status: sinon.stub().returns({ json: sinon.stub() }) };
-    const dataPromise = new Promise((resolve) => resolve({ foo: 'bar' }));
+    const dataPromise = Promise.resolve({ foo: 'bar' });
 
     await responseBuilder.route(dataPromise, VError.HTTP_STATUS.NO_CONTENT)({ originalUrl: '/test' }, res);
 
@@ -89,7 +89,7 @@ describe('responseBuilder unit tests', () => {
   it('returns bad response with overridden code', async () => {
     const responseBuilder = new ResponseBuilder();
     const res = { status: sinon.stub().returns({ json: sinon.stub() }) };
-    const dataPromise = new Promise((resolve, reject) => reject(new VError('boom')));
+    const dataPromise = Promise.reject(new VError('boom'));
 
     await responseBuilder.route(dataPromise, undefined, VError.HTTP_STATUS.BAD_REQUEST)({ originalUrl: '/test' }, res);
 
@@ -130,7 +130,7 @@ describe('responseBuilder unit tests', () => {
   it('returns bad response with Error', async () => {
     const responseBuilder = new ResponseBuilder();
     const res = { status: sinon.stub().returns({ json: sinon.stub() }) };
-    const dataPromise = new Promise((resolve, reject) => reject(new Error('boom')));
+    const dataPromise = Promise.reject(new VError('boom'));
 
     await responseBuilder.route(dataPromise)({ originalUrl: '/test' }, res);
 
@@ -153,7 +153,7 @@ describe('responseBuilder unit tests', () => {
   it('returns bad response with code 503', async () => {
     const responseBuilder = new ResponseBuilder();
     const res = { status: sinon.stub().returns({ json: sinon.stub() }) };
-    const dataPromise = new Promise((resolve, reject) => reject(new VError('boom', HttpStatus.SERVICE_UNAVAILABLE)));
+    const dataPromise = Promise.reject(new VError('boom', HttpStatus.SERVICE_UNAVAILABLE));
 
     await responseBuilder.route(dataPromise)({ originalUrl: '/test' }, res);
 
@@ -176,7 +176,7 @@ describe('responseBuilder unit tests', () => {
   it('returns bad response with data', async () => {
     const responseBuilder = new ResponseBuilder();
     const res = { status: sinon.stub().returns({ json: sinon.stub() }) };
-    const dataPromise = new Promise((resolve, reject) => reject(new VError('boom', undefined, { foo: 'bar' })));
+    const dataPromise = Promise.reject(new VError('boom', undefined, { foo: 'bar' }));
 
     await responseBuilder.route(dataPromise)({ originalUrl: '/test' }, res);
 
@@ -189,27 +189,4 @@ describe('responseBuilder unit tests', () => {
 
     expect(res.status().json.args[0][0]).to.eql({ foo: 'bar' });
   });
-
-  it('returns bad response with data from message', async () => {
-    const responseBuilder = new ResponseBuilder();
-    const res = { status: sinon.stub().returns({ json: sinon.stub() }) };
-    const dataPromise = new Promise((resolve, reject) => reject(new VError('boom')));
-
-    await responseBuilder.route(dataPromise)({ originalUrl: '/test' }, res);
-
-    const expected = {
-      code: 500,
-      status: 'Internal Server Error',
-      data: 'boom',
-    };
-
-    expect(res.status.args[0][0]).to.eql(expected.code);
-
-    expect(res.status().json.args[0][0].code).to.eql(expected.code);
-    expect(res.status().json.args[0][0].data).to.eql(expected.data);
-    expect(res.status().json.args[0][0].status).to.eql(expected.status);
-
-    expect(res.status().json.args[0][0].dateTime).to.not.be.undefined;
-    expect(res.status().json.args[0][0].timestamp).to.not.be.undefined;
-  });
 });

tsconfig.json

@@ -2,7 +2,7 @@
   "extends": "@voiceflow/tsconfig",
   "compilerOptions": {
     "baseUrl": "./src",
-    "lib": ["DOM", "ES2020"]
+    "lib": ["ES2020"]
   },
   "compileOnSave": false,
   "include": [