lib: use PRINTF_LIKE instead of pragma's to ignore -Wformat-nonliteral

Author: Duncaen

lib/cb_util.c

@@ -28,14 +28,9 @@
 #include <stdlib.h>
 #include <string.h>
 #include <stdarg.h>
-#include <errno.h>
 
 #include "xbps_api_impl.h"
 
-#ifdef __clang__
-#pragma clang diagnostic ignored "-Wformat-nonliteral"
-#endif
-
 void HIDDEN
 xbps_set_cb_fetch(struct xbps_handle *xhp,
 		  off_t file_size,
@@ -62,7 +57,7 @@ xbps_set_cb_fetch(struct xbps_handle *xhp,
 	(*xhp->fetch_cb)(&xfcd, xhp->fetch_cb_data);
 }
 
-int HIDDEN
+int HIDDEN PRINTF_LIKE(5, 6)
 xbps_set_cb_state(struct xbps_handle *xhp,
 		  xbps_state_t state,
 		  int err,

lib/util.c

@@ -42,10 +42,6 @@
 
 #include "xbps_api_impl.h"
 
-#ifdef __clang__
-#pragma clang diagnostic ignored "-Wformat-nonliteral"
-#endif
-
 static bool
 is_revision(const char *str)
 {