lib: replace array iterator with for loop in get_pkg_in_array

Author: Duncaen

lib/plist_find.c

@@ -37,25 +37,20 @@
 static xbps_dictionary_t
 get_pkg_in_array(xbps_array_t array, const char *str, xbps_trans_type_t tt, bool virtual)
 {
-	xbps_object_t obj;
-	xbps_object_iterator_t iter;
+	xbps_object_t obj = NULL;
 	xbps_trans_type_t ttype;
 	bool found = false;
 
 	assert(array);
 	assert(str);
 
-	iter = xbps_array_iterator(array);
-	if (!iter)
-		return NULL;
-
-	while ((obj = xbps_object_iterator_next(iter))) {
+	for (unsigned int i = 0; i < xbps_array_count(array); i++) {
 		const char *pkgver = NULL;
 		char pkgname[XBPS_NAME_SIZE] = {0};
 
-		if (!xbps_dictionary_get_cstring_nocopy(obj, "pkgver", &pkgver)) {
-			continue;
-		}
+		obj = xbps_array_get(array, i);
+		if (!xbps_dictionary_get_cstring_nocopy(obj, "pkgver", &pkgver))
+			abort();
 		if (virtual) {
 			/*
 			 * Check if package pattern matches
@@ -87,7 +82,6 @@ get_pkg_in_array(xbps_array_t array, const char *str, xbps_trans_type_t tt, bool
 			}
 		}
 	}
-	xbps_object_iterator_release(iter);
 
 	ttype = xbps_transaction_pkg_type(obj);
 	if (found && tt && (ttype != tt)) {