lib/plist_find.c: avoid allocation

Duncaen · Duncaen · commit dd1769230440 · 2025-06-28T16:38:00.000+02:00
diff --git a/lib/plist_find.c b/lib/plist_find.c
@@ -329,12 +329,11 @@ xbps_find_virtualpkg_in_conf(struct xbps_handle *xhp,
 					continue;
 				}
 			} else {
-				char *vpkgver = xbps_xasprintf("%s-999999_1", vpkg_conf);
+				char vpkgver[XBPS_NAME_SIZE + sizeof("-999999_1")];
+				snprintf(buf, sizeof(buf), "%s-999999_1", vpkg_conf);
 				if (!xbps_pkgpattern_match(vpkgver, pkg)) {
-					free(vpkgver);
 					continue;
 				}
-				free(vpkgver);
 			}
 		} else if (xbps_pkg_version(pkg)) {
 			// XXX: this is the old behaviour of only matching pkgname's,

Original file line number	Diff line number	Diff line change
`@@ -329,12 +329,11 @@ xbps_find_virtualpkg_in_conf(struct xbps_handle *xhp,`
`329`	`329`	`continue;`
`330`	`330`	`}`
`331`	`331`	`} else {`
`332`		`- char *vpkgver = xbps_xasprintf("%s-999999_1", vpkg_conf);`
	`332`	`+ char vpkgver[XBPS_NAME_SIZE + sizeof("-999999_1")];`
	`333`	`+ snprintf(buf, sizeof(buf), "%s-999999_1", vpkg_conf);`
`333`	`334`	`if (!xbps_pkgpattern_match(vpkgver, pkg)) {`
`334`		`- free(vpkgver);`
`335`	`335`	`continue;`
`336`	`336`	`}`
`337`		`- free(vpkgver);`
`338`	`337`	`}`
`339`	`338`	`} else if (xbps_pkg_version(pkg)) {`
`340`	`339`	`// XXX: this is the old behaviour of only matching pkgname's,`