bin/xbps-remove: fix memory leak in --clean-cache

Duncaen · Duncaen · commit e88ad64d46db · 2025-12-07T01:38:25.000+01:00
diff --git a/bin/xbps-remove/clean-cache.c b/bin/xbps-remove/clean-cache.c
@@ -179,7 +179,8 @@ clean_cachedir(struct xbps_handle *xhp, bool uninstalled, bool drun)
 			.uninstalled = uninstalled,
 		};
 		rv = xbps_array_foreach_cb_multi(xhp, array, NULL, cleaner_cb, (void*)&data);
-		xbps_object_release(array);
 	}
+
+	xbps_object_release(array);
 	return rv;
 }

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,8 @@ clean_cachedir(struct xbps_handle *xhp, bool uninstalled, bool drun)`
`179`	`179`	`.uninstalled = uninstalled,`
`180`	`180`	`};`
`181`	`181`	`rv = xbps_array_foreach_cb_multi(xhp, array, NULL, cleaner_cb, (void*)&data);`
`182`		`- xbps_object_release(array);`
`183`	`182`	`}`
	`183`	`+`
	`184`	`+ xbps_object_release(array);`
`184`	`185`	`return rv;`
`185`	`186`	`}`