refactor: fix warning

Author: voidint

cli/install.go

@@ -65,7 +65,8 @@ func install(ctx *cli.Context) (err error) {
 	targetV := filepath.Join(versionsDir, vname)
 
 	// Check if the version is already installed.
-	if finfo, err := os.Stat(targetV); err == nil && finfo.IsDir() {
+	var finfo os.FileInfo
+	if finfo, err = os.Stat(targetV); err == nil && finfo.IsDir() {
 		return cli.Exit(fmt.Sprintf("[g] %q version has been installed.", vname), 1)
 	}
 

cli/self_uninstall.go

@@ -27,7 +27,7 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
-func selfUninstall(*cli.Context) (err error) {
+func selfUninstall(*cli.Context) error {
 	menu := wmenu.NewMenu("Are you sure you want to uninstall g?")
 	menu.IsYesNo(wmenu.DefY)
 	menu.Action(func(opts []wmenu.Opt) error {
@@ -43,7 +43,7 @@ func selfUninstall(*cli.Context) (err error) {
 		rmPaths := []string{exePath}
 
 		for {
-			if binPath, err := os.Readlink(exePath); err == nil && binPath != exePath {
+			if binPath, e := os.Readlink(exePath); e == nil && binPath != exePath {
 				rmPaths = append(rmPaths, binPath)
 				exePath = binPath
 			} else {
@@ -70,7 +70,7 @@ func selfUninstall(*cli.Context) (err error) {
 		}
 		return nil
 	})
-	if err = menu.Run(); err != nil {
+	if err := menu.Run(); err != nil {
 		return cli.Exit(errstring(err), 1)
 	}
 	return nil

cli/uninstall.go

@@ -27,7 +27,7 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
-func uninstall(ctx *cli.Context) (err error) {
+func uninstall(ctx *cli.Context) error {
 	vname := ctx.Args().First()
 	if vname == "" {
 		return cli.ShowSubcommandHelp(ctx)
@@ -38,7 +38,7 @@ func uninstall(ctx *cli.Context) (err error) {
 		return cli.Exit(fmt.Sprintf("[g] %q version is not installed", vname), 1)
 	}
 
-	if err = os.RemoveAll(targetV); err != nil {
+	if err := os.RemoveAll(targetV); err != nil {
 		return cli.Exit(wrapstring(fmt.Sprintf("Uninstall failed: %s", err.Error())), 1)
 	}
 	fmt.Printf("Uninstalled go%s\n", vname)

cli/use.go

@@ -28,7 +28,7 @@ import (
 	"github.com/urfave/cli/v2"
 )
 
-func use(ctx *cli.Context) (err error) {
+func use(ctx *cli.Context) error {
 	vname := ctx.Args().First()
 	if vname == "" {
 		return cli.ShowSubcommandHelp(ctx)
@@ -41,7 +41,7 @@ func use(ctx *cli.Context) (err error) {
 
 	_ = os.Remove(goroot)
 
-	if err = mkSymlink(targetV, goroot); err != nil {
+	if err := mkSymlink(targetV, goroot); err != nil {
 		return cli.Exit(errstring(err), 1)
 	}
 	if output, err := exec.Command(filepath.Join(goroot, "bin", "go"), "version").Output(); err == nil {