Skip to content

Commit eddf1bf

Browse files
fixed npmName and npmVersion params default values
1 parent ba024b8 commit eddf1bf

File tree

3 files changed

+6
-6
lines changed
  • typescript-generator-core/src/main/java/cz/habarta/typescript/generator
  • typescript-generator-gradle-plugin/src/main/java/cz/habarta/typescript/generator/gradle
  • typescript-generator-maven-plugin/src/main/java/cz/habarta/typescript/generator/maven

3 files changed

+6
-6
lines changed

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/Settings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ public void validate() {
142142
}
143143
if (generateNpmPackageJson) {
144144
if (npmName == null || npmVersion == null) {
145-
throw new RuntimeException("'npmName' and 'npmVersion' must be specified when generating NPM package.json.");
145+
throw new RuntimeException("'npmName' and 'npmVersion' must be specified when generating NPM 'package.json'.");
146146
}
147147
}
148148
if (!generateNpmPackageJson) {
149149
if (npmName != null || npmVersion != null) {
150-
throw new RuntimeException("'npmName' and 'npmVersion' is only applicable when generating NPM package.json.");
150+
throw new RuntimeException("'npmName' and 'npmVersion' is only applicable when generating NPM 'package.json'.");
151151
}
152152
}
153153
}

typescript-generator-gradle-plugin/src/main/java/cz/habarta/typescript/generator/gradle/GenerateTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ public void generate() throws Exception {
117117
settings.loadIncludePropertyAnnotations(classLoader, includePropertyAnnotations);
118118
settings.loadOptionalAnnotations(classLoader, optionalAnnotations);
119119
settings.generateNpmPackageJson = generateNpmPackageJson;
120-
settings.npmName = npmName != null ? npmName : getProject().getName();
121-
settings.npmVersion = npmVersion != null ? npmVersion : settings.getDefaultNpmVersion();
120+
settings.npmName = npmName != null && generateNpmPackageJson ? getProject().getName() : npmName;
121+
settings.npmVersion = npmVersion != null && generateNpmPackageJson ? settings.getDefaultNpmVersion() : npmVersion;
122122
settings.setStringQuotes(stringQuotes);
123123
settings.displaySerializerWarning = displaySerializerWarning;
124124
settings.disableJackson2ModuleDiscovery = disableJackson2ModuleDiscovery;

typescript-generator-maven-plugin/src/main/java/cz/habarta/typescript/generator/maven/GenerateMojo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,8 @@ public void execute() {
409409
settings.loadIncludePropertyAnnotations(classLoader, includePropertyAnnotations);
410410
settings.loadOptionalAnnotations(classLoader, optionalAnnotations);
411411
settings.generateNpmPackageJson = generateNpmPackageJson;
412-
settings.npmName = npmName != null ? npmName : project.getArtifactId();
413-
settings.npmVersion = npmVersion != null ? npmVersion : settings.getDefaultNpmVersion();
412+
settings.npmName = npmName == null && generateNpmPackageJson ? project.getArtifactId() : npmName;
413+
settings.npmVersion = npmVersion == null && generateNpmPackageJson ? settings.getDefaultNpmVersion() : npmVersion;
414414
settings.setStringQuotes(stringQuotes);
415415
settings.displaySerializerWarning = displaySerializerWarning;
416416
settings.disableJackson2ModuleDiscovery = disableJackson2ModuleDiscovery;

0 commit comments

Comments
 (0)