code review

Author: paulkermann

volatility3/framework/automagic/pdbscan.py

@@ -212,8 +212,7 @@ def _method_layer_pdb_scan(self,
                                           start = start_scan_address,
                                           page_size = vlayer.page_size,
                                           pdb_names = kernel_pdb_names,
-                                          progress_callback = progress_callback,
-                                          maximum_invalid_count = constants.windows.PE_MAX_EXTRACTION_SIZE // 0x1000)
+                                          progress_callback = progress_callback)
         for kernel in kernels:
             valid_kernel = test_kernel(physical_layer_name, virtual_layer_name, kernel)
             if valid_kernel is not None:

volatility3/framework/symbols/windows/pdbutil.py

@@ -264,6 +264,14 @@ def pdbname_scan(cls,
 
         The UI should always provide the user an opportunity to specify the
         appropriate types and PDB values themselves
+        Args:
+            layer_name: The layer name to scan
+            page_size: Size of page constant
+            pdb_names: List of pdb names to scan
+            progress_callback: Means of providing the user with feedback during long processes
+            start: Start address to start scanning from the pdb_names
+            end: Minimum address to scan the pdb_names
+            maximum_invalid_count: Amount of pages that can be invalid during scanning before aborting signature search
         """
         min_pfn = 0