Skip to content

Commit 6653b93

Browse files
committed
volshell: update longest_typename calculations to use min() that than if statement
1 parent c43a1f4 commit 6653b93

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

volatility3/cli/volshell/generic.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,9 +489,12 @@ def display_type(
489489
member_type_name = self._get_type_name_with_pointer(
490490
member_type
491491
) # special case for pointers to show what they point to
492+
493+
# find the longest typename
492494
longest_typename = max(len(member_type_name), longest_typename)
493-
if longest_typename > MAX_TYPENAME_DISPLAY_LENGTH:
494-
longest_typename = MAX_TYPENAME_DISPLAY_LENGTH
495+
496+
# if the typename is very long then limit it to MAX_TYPENAME_DISPLAY_LENGTH
497+
longest_typename = min(longest_typename, MAX_TYPENAME_DISPLAY_LENGTH)
495498

496499
for member in sorted(
497500
volobject.vol.members, key=lambda x: (volobject.vol.members[x][0], x)

0 commit comments

Comments
 (0)