Skip to content

Commit b8d68b9

Browse files
committed
PR review fixes: Avoid using renderers in core functions.
1 parent 79529fb commit b8d68b9

File tree

1 file changed

+6
-6
lines changed
  • volatility3/framework/symbols/linux/extensions

1 file changed

+6
-6
lines changed

volatility3/framework/symbols/linux/extensions/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
import stat
88
from datetime import datetime
99
import socket as socket_module
10-
from typing import Generator, Iterable, Iterator, Optional, Tuple, List
10+
from typing import Generator, Iterable, Iterator, Optional, Tuple, List, Union
1111

1212
from volatility3.framework import constants, exceptions, objects, interfaces, symbols
13-
from volatility3.framework import renderers
13+
from volatility3.framework.renderers import conversion
1414
from volatility3.framework.constants.linux import SOCK_TYPES, SOCK_FAMILY
1515
from volatility3.framework.constants.linux import IP_PROTOCOLS, IPV6_PROTOCOLS
1616
from volatility3.framework.constants.linux import TCP_STATES, NETLINK_PROTOCOLS
@@ -1770,7 +1770,7 @@ class timespec64(objects.StructType):
17701770
def to_datetime(self) -> datetime:
17711771
"""Returns the respective aware datetime"""
17721772

1773-
dt = renderers.conversion.unixtime_to_datetime(self.tv_sec + self.tv_nsec / 1e9)
1773+
dt = conversion.unixtime_to_datetime(self.tv_sec + self.tv_nsec / 1e9)
17741774
return dt
17751775

17761776

@@ -1812,7 +1812,7 @@ def is_sticky(self) -> bool:
18121812
"""Returns True if the sticky bit is set"""
18131813
return (self.i_mode & stat.S_ISVTX) != 0
18141814

1815-
def get_inode_type(self) -> str:
1815+
def get_inode_type(self) -> Union[str, None]:
18161816
"""Returns inode type name
18171817
18181818
Returns:
@@ -1833,7 +1833,7 @@ def get_inode_type(self) -> str:
18331833
elif self.is_block():
18341834
return "BLK"
18351835
else:
1836-
return renderers.UnparsableValue()
1836+
return None
18371837

18381838
def get_inode_number(self) -> int:
18391839
"""Returns the inode number"""
@@ -1843,7 +1843,7 @@ def _time_member_to_datetime(self, member) -> datetime:
18431843
if self.has_member(f"{member}_sec") and self.has_member(f"{member}_nsec"):
18441844
# kernels >= 6.11 it's i_*_sec -> time64_t and i_*_nsec -> u32
18451845
# Ref Linux commit 3aa63a569c64e708df547a8913c84e64a06e7853
1846-
return renderers.conversion.unixtime_to_datetime(
1846+
return conversion.unixtime_to_datetime(
18471847
self.member(f"{member}_sec") + self.has_member(f"{member}_nsec") / 1e9
18481848
)
18491849
elif self.has_member(f"__{member}"):

0 commit comments

Comments
 (0)