Skip to content

Commit 11a7ae8

Browse files
committed
remove unnecessary return values
1 parent 8eb63bd commit 11a7ae8

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

tests/test_tos.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ async def test_upload_bytes_success(tos_client, mock_client):
108108
data = b"hello world"
109109

110110
result = await tos_client.upload("obj-key", data)
111-
assert result is True
111+
assert result is None
112112
mock_client.put_object.assert_called_once()
113113
mock_client.close.assert_called_once()
114114

@@ -121,7 +121,7 @@ async def test_upload_file_success(tmp_path, tos_client, mock_client):
121121
file_path.write_text("hello file")
122122

123123
result = await tos_client.upload("obj-key", str(file_path))
124-
assert result is True
124+
assert result is None
125125
mock_client.put_object_from_file.assert_called_once()
126126
mock_client.close.assert_called_once()
127127

veadk/integrations/ve_tos/ve_tos.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -130,40 +130,40 @@ def upload(
130130
logger.error(error_msg)
131131
raise ValueError(error_msg)
132132

133-
def _do_upload_bytes(self, object_key: str, data: bytes) -> bool:
133+
def _do_upload_bytes(self, object_key: str, data: bytes) -> None:
134134
try:
135135
if not self._client:
136-
return False
136+
return
137137
if not self.create_bucket():
138-
return False
138+
return
139139
self._client.put_object(
140140
bucket=self.config.bucket_name, key=object_key, content=data
141141
)
142142
logger.debug(f"Upload success, object_key: {object_key}")
143143
self._close()
144-
return True
144+
return
145145
except Exception as e:
146146
logger.error(f"Upload failed: {e}")
147147
self._close()
148-
return False
148+
return
149149

150-
def _do_upload_file(self, object_key: str, file_path: str) -> bool:
150+
def _do_upload_file(self, object_key: str, file_path: str) -> None:
151151
try:
152152
if not self._client:
153-
return False
153+
return
154154
if not self.create_bucket():
155-
return False
155+
return
156156

157157
self._client.put_object_from_file(
158158
bucket=self.config.bucket_name, key=object_key, file_path=file_path
159159
)
160160
self._close()
161161
logger.debug(f"Upload success, object_key: {object_key}")
162-
return True
162+
return
163163
except Exception as e:
164164
logger.error(f"Upload failed: {e}")
165165
self._close()
166-
return False
166+
return
167167

168168
def download(self, object_key: str, save_path: str) -> bool:
169169
"""download image from TOS"""

0 commit comments

Comments
 (0)