Skip to content

Commit 5219b42

Browse files
committed
fix: remove do hooks of tracer
1 parent c5bcd43 commit 5219b42

File tree

4 files changed

+0
-44
lines changed

4 files changed

+0
-44
lines changed

veadk/agents/loop_agent.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from pydantic import ConfigDict, Field
2020
from typing_extensions import Any
2121

22-
from veadk.agent import Agent
2322
from veadk.prompts.agent_default_prompt import DEFAULT_DESCRIPTION, DEFAULT_INSTRUCTION
2423
from veadk.tracing.base_tracer import BaseTracer
2524
from veadk.utils.logger import get_logger
@@ -50,21 +49,7 @@ class LoopAgent(GoogleADKLoopAgent):
5049
tracers: list[BaseTracer] = []
5150
"""The tracers provided to agent."""
5251

53-
def set_sub_agents_tracer(self, tracer) -> None:
54-
from veadk.agents.parallel_agent import ParallelAgent
55-
from veadk.agents.sequential_agent import SequentialAgent
56-
57-
for sub_agent in self.sub_agents:
58-
if isinstance(sub_agent, Agent):
59-
tracer.do_hooks(sub_agent)
60-
elif isinstance(sub_agent, (SequentialAgent, LoopAgent, ParallelAgent)):
61-
sub_agent.set_sub_agents_tracer(tracer)
62-
6352
def model_post_init(self, __context: Any) -> None:
6453
super().model_post_init(None) # for sub_agents init
6554

66-
if self.tracers:
67-
for tracer in self.tracers:
68-
self.set_sub_agents_tracer(tracer)
69-
7055
logger.info(f"{self.__class__.__name__} `{self.name}` init done.")

veadk/agents/parallel_agent.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from pydantic import ConfigDict, Field
2020
from typing_extensions import Any
2121

22-
from veadk.agent import Agent
2322
from veadk.prompts.agent_default_prompt import DEFAULT_DESCRIPTION, DEFAULT_INSTRUCTION
2423
from veadk.tracing.base_tracer import BaseTracer
2524
from veadk.utils.logger import get_logger
@@ -50,24 +49,12 @@ class ParallelAgent(GoogleADKParallelAgent):
5049
tracers: list[BaseTracer] = []
5150
"""The tracers provided to agent."""
5251

53-
def set_sub_agents_tracer(self, tracer) -> None:
54-
from veadk.agents.loop_agent import LoopAgent
55-
from veadk.agents.sequential_agent import SequentialAgent
56-
57-
for sub_agent in self.sub_agents:
58-
if isinstance(sub_agent, Agent):
59-
tracer.do_hooks(sub_agent)
60-
elif isinstance(sub_agent, (SequentialAgent, LoopAgent, ParallelAgent)):
61-
sub_agent.set_sub_agents_tracer(tracer)
62-
6352
def model_post_init(self, __context: Any) -> None:
6453
super().model_post_init(None) # for sub_agents init
6554

6655
if self.tracers:
6756
logger.warning(
6857
"Enable tracing in ParallelAgent may cause OpenTelemetry context error. Issue see https://github.com/google/adk-python/issues/1670"
6958
)
70-
for tracer in self.tracers:
71-
self.set_sub_agents_tracer(tracer)
7259

7360
logger.info(f"{self.__class__.__name__} `{self.name}` init done.")

veadk/agents/sequential_agent.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from pydantic import ConfigDict, Field
2020
from typing_extensions import Any
2121

22-
from veadk.agent import Agent
2322
from veadk.prompts.agent_default_prompt import DEFAULT_DESCRIPTION, DEFAULT_INSTRUCTION
2423
from veadk.tracing.base_tracer import BaseTracer
2524
from veadk.utils.logger import get_logger
@@ -50,21 +49,7 @@ class SequentialAgent(GoogleADKSequentialAgent):
5049
tracers: list[BaseTracer] = []
5150
"""The tracers provided to agent."""
5251

53-
def set_sub_agents_tracer(self, tracer) -> None:
54-
from veadk.agents.loop_agent import LoopAgent
55-
from veadk.agents.parallel_agent import ParallelAgent
56-
57-
for sub_agent in self.sub_agents:
58-
if isinstance(sub_agent, Agent):
59-
tracer.do_hooks(sub_agent)
60-
elif isinstance(sub_agent, (SequentialAgent, LoopAgent, ParallelAgent)):
61-
sub_agent.set_sub_agents_tracer(tracer)
62-
6352
def model_post_init(self, __context: Any) -> None:
6453
super().model_post_init(None) # for sub_agents init
6554

66-
if self.tracers:
67-
for tracer in self.tracers:
68-
self.set_sub_agents_tracer(tracer)
69-
7055
logger.info(f"{self.__class__.__name__} `{self.name}` init done.")

veadk/integrations/ve_faas/template/{{cookiecutter.local_dir_name}}/src/app.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ def load_tracer() -> None:
7474
name="veadk_tracer", app_name=agent_run_config.app_name, exporters=exporters
7575
)
7676
agent_run_config.agent.tracers.extend([tracer])
77-
tracer.do_hooks(agent=agent_run_config.agent)
7877

7978

8079
def build_mcp_run_agent_func() -> Callable:

0 commit comments

Comments
 (0)