feat(viking_url): viking mem and db envs (DATABASE_VIKINGMEM_BASE_URL and DATABASE_VIKING_BASE_URL) only for http private and raise error

Author: floritange

veadk/integrations/ve_viking_db_memory/ve_viking_db_memory.py

@@ -51,13 +51,20 @@ def __init__(
         ak="",
         sk="",
         sts_token="",
-        scheme="http",
+        scheme="https",
         connection_timeout=30,
         socket_timeout=30,
     ):
-        env_host = getenv("DATABASE_VIKINGMEM_BASE_URL", host)
-        if env_host.startswith("http://"):
-            env_host = env_host.replace("http://", "")
+        env_host = getenv(
+            "DATABASE_VIKINGMEM_BASE_URL", default_value=None, allow_false_values=True
+        )
+        if env_host is not None:
+            if env_host.startswith("http://"):
+                host = env_host.replace("http://", "")
+                scheme = "http"
+            else:
+                raise ValueError("DATABASE_VIKINGMEM_BASE_URL must start with http://")
+
         self.service_info = VikingDBMemoryClient.get_service_info(
             host, region, scheme, connection_timeout, socket_timeout
         )

veadk/knowledgebase/backends/vikingdb_knowledge_backend.py

@@ -557,16 +557,18 @@ def _do_request(
         path: str,
         method: Literal["GET", "POST", "PUT", "DELETE"] = "POST",
     ) -> dict:
-        VIKINGDB_KNOWLEDGEBASE_BASE_URL = getenv(
-            "DATABASE_VIKING_BASE_URL", "api-knowledgebase.mlp.cn-beijing.volces.com"
+        VIKINGDB_KNOWLEDGEBASE_BASE_URL = "api-knowledgebase.mlp.cn-beijing.volces.com"
+        full_path = f"https://{VIKINGDB_KNOWLEDGEBASE_BASE_URL}{path}"
+
+        env_host = getenv(
+            "DATABASE_VIKING_BASE_URL", default_value=None, allow_false_values=True
         )
-        if VIKINGDB_KNOWLEDGEBASE_BASE_URL.startswith("http://"):
-            VIKINGDB_KNOWLEDGEBASE_BASE_URL = VIKINGDB_KNOWLEDGEBASE_BASE_URL.replace(
-                "http://", ""
-            )
-            full_path = f"http://{VIKINGDB_KNOWLEDGEBASE_BASE_URL}{path}"
-        else:
-            full_path = f"https://{VIKINGDB_KNOWLEDGEBASE_BASE_URL}{path}"
+        if env_host is not None:
+            if env_host.startswith("http://"):
+                VIKINGDB_KNOWLEDGEBASE_BASE_URL = env_host.replace("http://", "")
+                full_path = f"http://{VIKINGDB_KNOWLEDGEBASE_BASE_URL}{path}"
+            else:
+                raise ValueError("DATABASE_VIKING_BASE_URL must start with http://")
 
         volcengine_access_key = self.volcengine_access_key
         volcengine_secret_key = self.volcengine_secret_key