removal of unavailable peers

Author: mimol91

node/peerdiscovery.go

@@ -8,7 +8,9 @@ import (
 
 	"github.com/volodymyrprokopyuk/go-blockchain/node/rpc"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/credentials/insecure"
+	"google.golang.org/grpc/status"
 )
 
 type PeerReader interface {
@@ -103,6 +105,12 @@ func (d *PeerDiscovery) DiscoverPeers(period time.Duration) {
       for _, peer := range d.Peers() {
         if peer != d.cfg.NodeAddr {
           peers, err := d.grpcPeerDiscover(peer)
+          if errorStatus, ok := status.FromError(err); ok {
+            if errorStatus.Code() == codes.Unavailable {
+              delete(d.peers, peer)
+              continue
+            }
+          }
           if err != nil {
             fmt.Println(err)
             continue

node/peerdiscovery_test.go

@@ -24,7 +24,7 @@ func createPeerDiscovery(
   peerDisc := node.NewPeerDiscovery(ctx, wg, peerDiscCfg)
   if start {
     wg.Add(1)
-    go peerDisc.DiscoverPeers(100 * time.Millisecond)
+    go peerDisc.DiscoverPeers(50 * time.Millisecond)
   }
   return peerDisc
 }
@@ -52,3 +52,41 @@ func TestPeerDiscovery(t *testing.T) {
     t.Errorf("bootstrap address %v is not in node known peers", bootAddr)
   }
 }
+
+func TestRemovalOfUnhealthyPeer(t *testing.T) {
+  wg := new(sync.WaitGroup)
+  // Create the peer discovery without staring for the bootstrap node
+  bootPeerDisc := createPeerDiscovery(t.Context(), wg, true, false)
+  // Start the gRPC server on the bootstrap node
+
+  waitForPeersDiscovery := make(chan struct{})
+  grpcStartSvr(t, bootAddr, func(grpcSrv *grpc.Server) {
+    node := rpc.NewNodeSrv(bootPeerDisc, nil)
+    rpc.RegisterNodeServer(grpcSrv, node)
+
+    go func() {
+      <-waitForPeersDiscovery
+      grpcSrv.Stop()
+    }()
+  })
+  // Create and start the peer discovery for the new node
+  nodePeerDisc := createPeerDiscovery(t.Context(), wg, false, true)
+  // Wait for the peer discovery to discover peers
+  time.Sleep(150 * time.Millisecond)
+  // Verify that the bootstrap node and the new node have discovered each other
+
+  if !slices.Contains(bootPeerDisc.Peers(), nodeAddr) {
+    t.Errorf("node address %v is not in bootstrap known peers", nodeAddr)
+  }
+  if !slices.Contains(nodePeerDisc.Peers(), bootAddr) {
+    t.Errorf("bootstrap address %v is not in node known peers", bootAddr)
+  }
+
+  waitForPeersDiscovery <- struct{}{}
+  // Wait for the peer discovery to try to discover peers
+  time.Sleep(150 * time.Millisecond)
+
+  if len(nodePeerDisc.Peers()) != 0 {
+    t.Errorf("node peer discovery should not have any peers after the bootstrap node is stopped")
+  }
+}