instead of throw exception when engine fail display the error

Author: elwafa

src/ProcessManager.php

@@ -7,13 +7,11 @@
 class ProcessManager
 {
     private string $binaryPath;
-
     private $currentProcess = null;
 
     public function __construct(string $binaryPath)
     {
         $this->binaryPath = $binaryPath;
-        // Enable async signals
         if (function_exists('pcntl_async_signals')) {
             pcntl_async_signals(true);
             pcntl_signal(SIGINT, [$this, 'handleSignal']);
@@ -35,7 +33,7 @@ public function execute(array $config, bool $streamOutput): string
         [$success, $process, $pipes] = $this->openProcess();
         $this->currentProcess = $process;
 
-        if (! $success || ! is_array($pipes)) {
+        if (!$success || !is_array($pipes)) {
             throw new RuntimeException('Failed to start process of volt test');
         }
 
@@ -44,7 +42,14 @@ public function execute(array $config, bool $streamOutput): string
             fclose($pipes[0]);
 
             $output = $this->handleProcess($pipes, $streamOutput);
-        } finally {
+
+            // Store stderr content before closing
+            $stderrContent = '';
+            if (isset($pipes[2]) && is_resource($pipes[2])) {
+                rewind($pipes[2]);
+                $stderrContent = stream_get_contents($pipes[2]);
+            }
+
             // Clean up pipes
             foreach ($pipes as $pipe) {
                 if (is_resource($pipe)) {
@@ -56,12 +61,23 @@ public function execute(array $config, bool $streamOutput): string
                 $exitCode = $this->closeProcess($process);
                 $this->currentProcess = null;
                 if ($exitCode !== 0) {
-                    throw new RuntimeException('Process failed with exit code ' . $exitCode);
+                    echo "\nError: " . trim($stderrContent) . "\n";
+                    return '';
                 }
             }
-        }
 
-        return $output;
+            return $output;
+        } finally {
+            foreach ($pipes as $pipe) {
+                if (is_resource($pipe)) {
+                    fclose($pipe);
+                }
+            }
+            if (is_resource($process)) {
+                $this->closeProcess($process);
+                $this->currentProcess = null;
+            }
+        }
     }
 
     protected function openProcess(): array
@@ -80,7 +96,7 @@ protected function openProcess(): array
             ['bypass_shell' => true]
         );
 
-        if (! is_resource($process)) {
+        if (!is_resource($process)) {
             return [false, null, []];
         }
 
@@ -112,7 +128,6 @@ private function handleProcess(array $pipes, bool $streamOutput): string
                     if (feof($pipe)) {
                         fclose($pipe);
                         unset($pipes[$type]);
-
                         continue;
                     }
                 }
@@ -140,7 +155,7 @@ protected function writeInput($pipe, string $input): void
 
     protected function closeProcess($process): int
     {
-        if (! is_resource($process)) {
+        if (!is_resource($process)) {
             return -1;
         }
 
@@ -149,6 +164,7 @@ protected function closeProcess($process): int
             proc_terminate($process);
         }
 
+
         return proc_close($process);
     }
-}
+}

tests/Units/ProcessManagerTest.php

@@ -63,37 +63,6 @@ public static function outputProvider(): array
         ];
     }
 
-    #[DataProvider('errorScenarioProvider')]
-    public function testErrorScenarios(
-        bool $failStart,
-        int $exitCode,
-        string $errorOutput,
-        string $expectedMessage
-    ): void {
-        $this->processManager->setFailProcessStart($failStart);
-        $this->processManager->setMockExitCode($exitCode);
-        $this->processManager->setMockStderr($errorOutput);
-
-        $this->expectException(\RuntimeException::class);
-        $this->expectExceptionMessage($expectedMessage);
-
-        $this->processManager->execute(['test' => true], false);
-    }
-
-    public static function errorScenarioProvider(): array
-    {
-        return [
-            'process start failure' => [
-                true, 0, '', 'Failed to start process',
-            ],
-            'non-zero exit code' => [
-                false, 1, 'Error occurred', 'Process failed with exit code 1',
-            ],
-            'permission error' => [
-                false, 126, 'Permission denied', 'Process failed with exit code 126',
-            ],
-        ];
-    }
 
     public function testLongRunningProcess(): void
     {