also add some smoke tests, and update from node v12

Author: mikrostew

tests/smoke/autodownload.rs

@@ -7,23 +7,31 @@ use test_support::matchers::execs;
 static PACKAGE_JSON_WITH_PINNED_NODE: &str = r#"{
     "name": "test-package",
     "volta": {
-        "node": "12.13.0"
+        "node": "14.15.5"
     }
 }"#;
 
 static PACKAGE_JSON_WITH_PINNED_NODE_NPM: &str = r#"{
     "name": "test-package",
     "volta": {
-        "node": "13.0.1",
-        "npm": "6.13.4"
+        "node": "17.3.0",
+        "npm": "8.5.1"
     }
 }"#;
 
-static PACKAGE_JSON_WITH_PINNED_NODE_YARN: &str = r#"{
+static PACKAGE_JSON_WITH_PINNED_NODE_YARN_1: &str = r#"{
     "name": "test-package",
     "volta": {
-        "node": "12.10.0",
-        "yarn": "1.22.0"
+        "node": "16.11.1",
+        "yarn": "1.22.16"
+    }
+}"#;
+
+static PACKAGE_JSON_WITH_PINNED_NODE_YARN_3: &str = r#"{
+    "name": "test-package",
+    "volta": {
+        "node": "16.14.0",
+        "yarn": "3.1.0"
     }
 }"#;
 
@@ -35,7 +43,7 @@ fn autodownload_node() {
 
     assert_that!(
         p.node("--version"),
-        execs().with_status(0).with_stdout_contains("v12.13.0")
+        execs().with_status(0).with_stdout_contains("v14.15.5")
     );
 }
 
@@ -47,18 +55,31 @@ fn autodownload_npm() {
 
     assert_that!(
         p.npm("--version"),
-        execs().with_status(0).with_stdout_contains("6.13.4")
+        execs().with_status(0).with_stdout_contains("8.5.1")
+    );
+}
+
+#[test]
+fn autodownload_yarn_1() {
+    let p = temp_project()
+        .package_json(PACKAGE_JSON_WITH_PINNED_NODE_YARN_1)
+        .build();
+
+    assert_that!(
+        p.yarn("--version"),
+        execs().with_status(0).with_stdout_contains("1.22.16")
     );
 }
 
 #[test]
-fn autodownload_yarn() {
+fn autodownload_yarn_3() {
     let p = temp_project()
-        .package_json(PACKAGE_JSON_WITH_PINNED_NODE_YARN)
+        .package_json(PACKAGE_JSON_WITH_PINNED_NODE_YARN_3)
+        .env("VOLTA_FEATURE_YARN_3", "true")
         .build();
 
     assert_that!(
         p.yarn("--version"),
-        execs().with_status(0).with_stdout_contains("1.22.0")
+        execs().with_status(0).with_stdout_contains("3.1.0")
     );
 }

tests/smoke/npm_link.rs

@@ -49,7 +49,7 @@ fn link_global_into_current_project() {
     let p = temp_project().package_json(PACKAGE_JSON).build();
 
     assert_that!(
-        p.volta("install node@12.19.1 [email protected]"),
+        p.volta("install node@14.19.0 [email protected]"),
         execs().with_status(0)
     );
 

tests/smoke/package_migration.rs

@@ -9,7 +9,7 @@ const LEGACY_PACKAGE_CONFIG: &str = r#"{
   "version": "1.1.7",
   "platform": {
     "node": {
-      "runtime": "12.18.3",
+      "runtime": "14.18.2",
       "npm": null
     },
     "yarn": null
@@ -27,7 +27,7 @@ const LEGACY_BIN_CONFIG: &str = r#"{
   "path": "./cli.js",
   "platform": {
     "node": {
-      "runtime": "12.18.3",
+      "runtime": "14.18.2",
       "npm": null
     },
     "yarn": null

tests/smoke/support/temp_project.rs

@@ -40,6 +40,20 @@ impl FileBuilder {
     }
 }
 
+pub struct EnvVar {
+    name: String,
+    value: String,
+}
+
+impl EnvVar {
+    pub fn new(name: &str, value: &str) -> Self {
+        EnvVar {
+            name: name.to_string(),
+            value: value.to_string(),
+        }
+    }
+}
+
 #[must_use]
 pub struct TempProjectBuilder {
     root: TempProject,
@@ -57,6 +71,7 @@ impl TempProjectBuilder {
             root: TempProject {
                 root: root.clone(),
                 path: OsString::new(),
+                env_vars: vec![],
             },
             files: vec![],
         }
@@ -83,6 +98,12 @@ impl TempProjectBuilder {
         self
     }
 
+    /// Set an environment variable (chainable)
+    pub fn env(mut self, name: &str, value: &str) -> Self {
+        self.root.env_vars.push(EnvVar::new(name, value));
+        self
+    }
+
     /// Create the project
     pub fn build(mut self) -> TempProject {
         // First, clean the temporary project directory if it already exists
@@ -248,6 +269,7 @@ fn package_distro_file_name(name: &str, version: &str) -> String {
 pub struct TempProject {
     root: PathBuf,
     path: OsString,
+    env_vars: Vec<EnvVar>,
 }
 
 impl TempProject {
@@ -273,6 +295,11 @@ impl TempProject {
             .env_remove("VOLTA_NODE_VERSION")
             .env_remove("MSYSTEM"); // assume cmd.exe everywhere on windows
 
+        // overrides for env vars
+        for env_var in &self.env_vars {
+            p.env(&env_var.name, &env_var.value);
+        }
+
         p
     }
 

tests/smoke/volta_fetch.rs

@@ -8,25 +8,34 @@ use test_support::matchers::execs;
 fn fetch_node() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("fetch node@12.16.0"), execs().with_status(0));
-    assert!(p.node_version_is_fetched("12.16.0"));
-    assert!(p.node_version_is_unpacked("12.16.0"));
+    assert_that!(p.volta("fetch node@14.17.6"), execs().with_status(0));
+    assert!(p.node_version_is_fetched("14.17.6"));
+    assert!(p.node_version_is_unpacked("14.17.6"));
 }
 
 #[test]
-fn fetch_yarn() {
+fn fetch_yarn_1() {
     let p = temp_project().build();
 
     assert_that!(p.volta("fetch [email protected]"), execs().with_status(0));
     assert!(p.yarn_version_is_fetched("1.22.1"));
     assert!(p.yarn_version_is_unpacked("1.22.1"));
 }
 
+#[test]
+fn fetch_yarn_3() {
+    let p = temp_project().env("VOLTA_FEATURE_YARN_3", "yes").build();
+
+    assert_that!(p.volta("fetch [email protected]"), execs().with_status(0));
+    assert!(p.yarn_version_is_fetched("3.2.0"));
+    assert!(p.yarn_version_is_unpacked("3.2.0"));
+}
+
 #[test]
 fn fetch_npm() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("fetch npm@6.14.2"), execs().with_status(0));
-    assert!(p.npm_version_is_fetched("6.14.2"));
-    assert!(p.npm_version_is_unpacked("6.14.2"));
+    assert_that!(p.volta("fetch npm@8.3.1"), execs().with_status(0));
+    assert!(p.npm_version_is_fetched("8.3.1"));
+    assert!(p.npm_version_is_unpacked("8.3.1"));
 }

tests/smoke/volta_install.rs

@@ -9,16 +9,16 @@ use test_support::matchers::execs;
 fn install_node() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("install node@12.16.2"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.15.4"), execs().with_status(0));
 
     assert_that!(
         p.node("--version"),
-        execs().with_status(0).with_stdout_contains("v12.16.2")
+        execs().with_status(0).with_stdout_contains("v14.15.4")
     );
 
-    assert!(p.node_version_is_fetched("12.16.2"));
-    assert!(p.node_version_is_unpacked("12.16.2"));
-    p.assert_node_version_is_installed("12.16.2");
+    assert!(p.node_version_is_fetched("14.15.4"));
+    assert!(p.node_version_is_unpacked("14.15.4"));
+    p.assert_node_version_is_installed("14.15.4");
 }
 
 #[test]
@@ -34,15 +34,15 @@ fn install_node_lts() {
 fn install_node_concurrent() {
     let p = temp_project().build();
 
-    let install = p.volta("install node@12.14.0");
+    let install = p.volta("install node@14.17.2");
     let run = p.node("--version");
 
     let concurrent_thread = thread::spawn(move || {
         assert_that!(install, execs().with_status(0));
         assert_that!(run, execs().with_status(0));
     });
 
-    assert_that!(p.volta("install node@12.14.0"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.17.2"), execs().with_status(0));
     assert_that!(p.node("--version"), execs().with_status(0));
 
     assert!(concurrent_thread.join().is_ok());
@@ -52,7 +52,7 @@ fn install_node_concurrent() {
 fn install_yarn() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("install node@12.16.3"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.15.2"), execs().with_status(0));
     assert_that!(p.volta("install [email protected]"), execs().with_status(0));
 
     assert_that!(
@@ -69,7 +69,7 @@ fn install_yarn() {
 fn install_old_yarn() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("install node@10.21.0"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.11.0"), execs().with_status(0));
     // Yarn 1.9.2 is old enough that it is no longer on the first page of results from the GitHub API
     assert_that!(p.volta("install [email protected]"), execs().with_status(0));
 
@@ -87,7 +87,7 @@ fn install_old_yarn() {
 fn install_yarn_concurrent() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("install node@12.14.0"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.19.0"), execs().with_status(0));
 
     let install = p.volta("install [email protected]");
     let run = p.yarn("--version");
@@ -107,30 +107,30 @@ fn install_yarn_concurrent() {
 fn install_npm() {
     let p = temp_project().build();
 
-    // node 13.10.0 is bundled with npm 6.13.7
-    assert_that!(p.volta("install node@13.10.0"), execs().with_status(0));
+    // node 17.6.0 is bundled with npm 8.5.1
+    assert_that!(p.volta("install node@17.6.0"), execs().with_status(0));
     assert_that!(
         p.npm("--version"),
-        execs().with_status(0).with_stdout_contains("6.13.7")
+        execs().with_status(0).with_stdout_contains("8.5.1")
     );
 
     // install npm 6.8.0 and verify that is installed correctly
-    assert_that!(p.volta("install npm@6.14.3"), execs().with_status(0));
-    assert!(p.npm_version_is_fetched("6.14.3"));
-    assert!(p.npm_version_is_unpacked("6.14.3"));
-    p.assert_npm_version_is_installed("6.14.3");
+    assert_that!(p.volta("install npm@8.5.5"), execs().with_status(0));
+    assert!(p.npm_version_is_fetched("8.5.5"));
+    assert!(p.npm_version_is_unpacked("8.5.5"));
+    p.assert_npm_version_is_installed("8.5.5");
 
     assert_that!(
         p.npm("--version"),
-        execs().with_status(0).with_stdout_contains("6.14.3")
+        execs().with_status(0).with_stdout_contains("8.5.5")
     );
 }
 
 #[test]
 fn install_npm_concurrent() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("install node@12.14.0"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.5.0"), execs().with_status(0));
 
     let install = p.volta("install [email protected]");
     let run = p.npm("--version");
@@ -160,7 +160,7 @@ fn install_package() {
     let p = temp_project().build();
 
     // have to install node first, because we need npm
-    assert_that!(p.volta("install node@12.11.1"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.11.0"), execs().with_status(0));
 
     assert_that!(p.volta("install [email protected]"), execs().with_status(0));
     assert!(p.shim_exists("cowsay"));
@@ -176,7 +176,7 @@ fn install_package() {
 fn install_package_concurrent() {
     let p = temp_project().build();
 
-    assert_that!(p.volta("install node@12.14.0"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.14.0"), execs().with_status(0));
 
     let install = p.volta("install [email protected]");
     let run = p.exec_shim("cowsay", "hello");
@@ -197,7 +197,7 @@ fn install_scoped_package() {
     let p = temp_project().build();
 
     // have to install node first, because we need npm
-    assert_that!(p.volta("install node@12.14.1"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.15.0"), execs().with_status(0));
 
     assert_that!(p.volta("install @wdio/[email protected]"), execs().with_status(0));
     assert!(p.shim_exists("wdio"));
@@ -214,7 +214,7 @@ fn install_package_tag_version() {
     let p = temp_project().build();
 
     // have to install node first, because we need npm
-    assert_that!(p.volta("install node@12.12.0"), execs().with_status(0));
+    assert_that!(p.volta("install node@14.8.0"), execs().with_status(0));
 
     assert_that!(p.volta("install [email protected]"), execs().with_status(0));
     assert!(p.shim_exists("elm"));