clean up temp files in tests

Author: mikrostew

crates/volta-core/src/monitor.rs

@@ -8,7 +8,7 @@ use tempfile::NamedTempFile;
 use crate::command::create_command;
 use crate::event::Event;
 
-/// send event to the spawned command process
+/// Send event to the spawned command process
 // if hook command is not configured, this is not called
 pub fn send_events(command: &str, events: &[Event]) {
     match serde_json::to_string_pretty(&events) {

tests/acceptance/hooks.rs

@@ -30,6 +30,8 @@ cfg_if::cfg_if! {
         // so just copy the tempfile (path in EVENTS_FILE env var) to events.json
         const EVENTS_EXECUTABLE: &str = r#"@echo off
 copy %EVENTS_FILE% events.json
+:: executables should clean up the temp file
+del %EVENTS_FILE%
 "#;
         const SCRIPT_FILENAME: &str = "write-events.bat";
         const VOLTA_BINARY: &str = "volta.exe";
@@ -43,6 +45,8 @@ while read line
 do
   echo "$line" >>events.json
 done
+# executables should clean up the temp file
+/bin/rm "$EVENTS_FILE"
 "#;
         const SCRIPT_FILENAME: &str = "write-events.sh";
         const VOLTA_BINARY: &str = "volta";

tests/acceptance/merged_platform.rs

@@ -58,13 +58,17 @@ cfg_if::cfg_if! {
         // copy the tempfile (path in EVENTS_FILE env var) to events.json
         const EVENTS_EXECUTABLE: &str = r#"@echo off
 copy %EVENTS_FILE% events.json
+:: executables should clean up the temp file
+del %EVENTS_FILE%
 "#;
         const SCRIPT_FILENAME: &str = "write-events.bat";
         const YARN_SHIM: &str = "yarn.exe";
     } else if #[cfg(unix)] {
         // copy the tempfile (path in EVENTS_FILE env var) to events.json
         const EVENTS_EXECUTABLE: &str = r#"#!/bin/bash
 /bin/cp "$EVENTS_FILE" events.json
+# executables should clean up the temp file
+/bin/rm "$EVENTS_FILE"
 "#;
         const SCRIPT_FILENAME: &str = "write-events.sh";
         const YARN_SHIM: &str = "yarn";