Skip to content

Commit eacff22

Browse files
authored
Merge pull request #1650 from charlespierce/winget_installer
Remove code signing and update installer icon
2 parents 6d6366f + 6fd47ee commit eacff22

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -87,24 +87,6 @@ jobs:
8787
- name: Compile and package installer
8888
run: |
8989
cargo wix --nocapture --package volta --output target\wix\volta-windows.msi
90-
- name: Load Certificate File
91-
id: certificate_file
92-
if: github.event_name == 'push'
93-
uses: timheuer/base64-to-file@v1
94-
with:
95-
fileName: "volta-certificate.pfx"
96-
encodedString: ${{ secrets.INSTALLER_CERTIFICATE }}
97-
- name: Sign Installer
98-
if: github.event_name == 'push'
99-
env:
100-
CERTIFICATE_FILE: ${{ steps.certificate_file.outputs.filePath }}
101-
CERTIFICATE_PASSWORD: ${{ secrets.INSTALLER_CERTIFICATE_PASSWORD }}
102-
run: |
103-
& "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x86\signtool.exe" sign /fd sha256 /f "$env:CERTIFICATE_FILE" /p "$env:CERTIFICATE_PASSWORD" /tr http://ts.ssl.com /td sha256 /d "Volta: Start Your Engines" /du "https://volta.sh" "target\wix\volta-windows.msi"
104-
- name: Verify Signature
105-
if: github.event_name == 'push'
106-
run: |
107-
& "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x86\signtool.exe" verify /pa "target\wix\volta-windows.msi"
10890
- name: Create zip of binaries
10991
run: powershell Compress-Archive volta*.exe volta-windows.zip
11092
working-directory: ./target/release

wix/volta.ico

-2.73 KB
Binary file not shown.

0 commit comments

Comments
 (0)