Fix some typos and add some internal documentation

Author: chriskrycho

crates/volta-core/src/error/kind.rs

@@ -443,10 +443,10 @@ pub enum ErrorKind {
         name: String,
     },
 
-    /// Thrown when serializnig a bin config to JSON fails
+    /// Thrown when serializing a bin config to JSON fails
     StringifyBinConfigError,
 
-    /// Thrown when serializnig a package config to JSON fails
+    /// Thrown when serializing a package config to JSON fails
     StringifyPackageConfigError,
 
     /// Thrown when serializing the platform to JSON fails

tests/acceptance/direct_uninstall.rs

@@ -1,3 +1,7 @@
+//! Tests for `npm uninstall`, `npm uninstall --global`, `yarn remove`, and
+//! `yarn global remove`, which we support as alternatives to `volta uninstall`
+//! and which should use its logic.
+
 use crate::support::sandbox::{sandbox, DistroMetadata, NodeFixture, Sandbox, Yarn1Fixture};
 use hamcrest2::assert_that;
 use hamcrest2::prelude::*;

tests/acceptance/volta_uninstall.rs

@@ -1,3 +1,5 @@
+//! Tests for `volta uninstall`.
+
 use crate::support::sandbox::{sandbox, Sandbox};
 use hamcrest2::assert_that;
 use hamcrest2::prelude::*;
@@ -94,6 +96,36 @@ fn uninstall_package_basic() {
     assert!(!Sandbox::package_image_exists("cowsay"));
 }
 
+#[test]
+fn uninstall_package_basic_with_version() {
+    // basic uninstall - everything exists, and everything except the cached
+    // inventory files should be deleted
+    let s = sandbox()
+        .package_config("cowsay", PKG_CONFIG_BASIC)
+        .binary_config("cowsay", &bin_config("cowsay"))
+        .binary_config("cowthink", &bin_config("cowthink"))
+        .shim("cowsay")
+        .shim("cowthink")
+        .package_image("cowsay", "1.4.0", None)
+        .env(VOLTA_LOGLEVEL, "info")
+        .build();
+
+    assert_that!(
+        s.volta("uninstall [email protected]"),
+        execs().with_status(1).with_stderr_contains(
+            "[..]error: uninstalling specific versions of tools is not supported yet."
+        )
+    );
+
+    // check that nothing is deleted.
+    assert!(Sandbox::package_config_exists("cowsay"));
+    assert!(Sandbox::bin_config_exists("cowsay"));
+    assert!(Sandbox::bin_config_exists("cowthink"));
+    assert!(Sandbox::shim_exists("cowsay"));
+    assert!(Sandbox::shim_exists("cowthink"));
+    assert!(Sandbox::package_image_exists("cowsay"));
+}
+
 #[test]
 fn uninstall_package_no_bins() {
     // the package doesn't contain any executables, it should uninstall without error