Optimize IpAddresses assignment logic

voltaney · voltaney · commit 6c96066a8386 · 2025-04-06T04:14:55.000+09:00
- Changed the assignment of `IpAddresses` to use the pre-fetched `candidateIpAddresses` list instead of calling `NetworkHelper.GetAllLocalIPv4()` twice.
- Improved code efficiency by avoiding redundant method calls.
diff --git a/TouchSenderTablet.GUI/ViewModels/MainViewModel.cs b/TouchSenderTablet.GUI/ViewModels/MainViewModel.cs
@@ -113,7 +113,7 @@ public MainViewModel(ITouchReceiverSettingsService touchReceiverSettingsService,
         _screenOptions = _touchReceiverSettingsService.ScreenOptions;
 
         var candidateIpAddresses = NetworkHelper.GetAllLocalIPv4().ToList();
-        IpAddresses = candidateIpAddresses.Count > 0 ? string.Join(" / ", NetworkHelper.GetAllLocalIPv4()) : "Unknown".GetLocalized();
+        IpAddresses = candidateIpAddresses.Count > 0 ? string.Join(" / ", candidateIpAddresses) : "Unknown".GetLocalized();
     }
 
     private void SetInitialCanvas()

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public MainViewModel(ITouchReceiverSettingsService touchReceiverSettingsService,`
`113`	`113`	`_screenOptions = _touchReceiverSettingsService.ScreenOptions;`
`114`	`114`
`115`	`115`	`var candidateIpAddresses = NetworkHelper.GetAllLocalIPv4().ToList();`
`116`		`- IpAddresses = candidateIpAddresses.Count > 0 ? string.Join(" / ", NetworkHelper.GetAllLocalIPv4()) : "Unknown".GetLocalized();`
	`116`	`+ IpAddresses = candidateIpAddresses.Count > 0 ? string.Join(" / ", candidateIpAddresses) : "Unknown".GetLocalized();`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`private void SetInitialCanvas()`