Skip to content

Commit 8b896d8

Browse files
vonbecmannvonbecmann
committed
fix critics
1 parent 316b3ff commit 8b896d8

27 files changed

+381
-317
lines changed

‎repository/EarleyParser-Core/Array.extension.st‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
Extension { #name : #Array }
1+
Extension { #name : 'Array' }
22

3-
{ #category : #'*EarleyParser-Core' }
3+
{ #category : '*EarleyParser-Core' }
44
Array >> asProductionRule [
55
^ NCProductionRule
66
headNamed: self first

‎repository/EarleyParser-Core/Association.extension.st‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
Extension { #name : #Association }
1+
Extension { #name : 'Association' }
22

3-
{ #category : #'*EarleyParser-Core' }
3+
{ #category : '*EarleyParser-Core' }
44
Association >> buildProductionRuleGiven: grammarBuilder [
55
^ NCProductionRule
66
head: (grammarBuilder nonTerminalNamed: self key)

‎repository/EarleyParser-Core/Dictionary.extension.st‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
Extension { #name : #Dictionary }
1+
Extension { #name : 'Dictionary' }
22

3-
{ #category : #'*EarleyParser-Core' }
3+
{ #category : '*EarleyParser-Core' }
44
Dictionary >> jeAt: firstKey at: secondKey ifAbsentPut: absentBlock [
55
| index |
66
index := self findElementOrNil: firstKey.
@@ -20,15 +20,15 @@ Dictionary >> jeAt: firstKey at: secondKey ifAbsentPut: absentBlock [
2020
ifNotNil: [:assoc | assoc value jeAt: secondKey ifAbsentPut: absentBlock ]
2121
]
2222

23-
{ #category : #'*EarleyParser-Core' }
23+
{ #category : '*EarleyParser-Core' }
2424
Dictionary >> jeAt: firstKey at: secondKey ifPresent: aPresentBlock ifAbsent: absentBlock [
2525
^ (array at: (self findElementOrNil: firstKey))
2626
ifNil: [ absentBlock value ]
2727
ifNotNil: [ :assoc |
2828
assoc value jeAt: secondKey ifPresent: aPresentBlock ifAbsent: absentBlock ]
2929
]
3030

31-
{ #category : #'*EarleyParser-Core' }
31+
{ #category : '*EarleyParser-Core' }
3232
Dictionary >> jeAt: key ifAbsentPut: absentBlock [
3333
"
3434
Return the value at the given key.
@@ -46,14 +46,14 @@ Dictionary >> jeAt: key ifAbsentPut: absentBlock [
4646
ifNotNil: [ :assoc | assoc ]) value
4747
]
4848

49-
{ #category : #'*EarleyParser-Core' }
49+
{ #category : '*EarleyParser-Core' }
5050
Dictionary >> jeAt: key ifPresent: aPresentBlock ifAbsent: absentBlock [
5151
^ (array at: (self findElementOrNil: key))
5252
ifNil: [ absentBlock value ]
5353
ifNotNil: [ :assoc | aPresentBlock cull: assoc value ]
5454
]
5555

56-
{ #category : #'*EarleyParser-Core' }
56+
{ #category : '*EarleyParser-Core' }
5757
Dictionary >> jeAt: key ifPresent: aPresentBlock ifAbsentPut: absentBlock [
5858
"
5959
Return the value at the given key.
@@ -71,7 +71,7 @@ Dictionary >> jeAt: key ifPresent: aPresentBlock ifAbsentPut: absentBlock [
7171
ifNotNil: [ :assoc | aPresentBlock cull: assoc value ]
7272
]
7373

74-
{ #category : #'*EarleyParser-Core' }
74+
{ #category : '*EarleyParser-Core' }
7575
Dictionary >> jeAt: key put: anObject [
7676
"Set the value at key to be anObject. If key is not found, create a
7777
new entry for key and set is value to anObject. Answer anObject."

‎repository/EarleyParser-Core/JEAlgorithm.class.st‎

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,22 @@ look-ahead will not be considered
44
55
"
66
Class {
7-
#name : #JEAlgorithm,
8-
#superclass : #Object,
7+
#name : 'JEAlgorithm',
8+
#superclass : 'Object',
99
#instVars : [
1010
'grammar'
1111
],
12-
#category : #'EarleyParser-Core-Implementation'
12+
#category : 'EarleyParser-Core-Implementation',
13+
#package : 'EarleyParser-Core',
14+
#tag : 'Implementation'
1315
}
1416

15-
{ #category : #'instance creation' }
17+
{ #category : 'instance creation' }
1618
JEAlgorithm class >> given: aGrammar [
1719
^ self basicNew initializeGrammar: aGrammar
1820
]
1921

20-
{ #category : #'private operations' }
22+
{ #category : 'private operations' }
2123
JEAlgorithm >> complete: item [
2224
"
2325
Complete:
@@ -30,7 +32,7 @@ JEAlgorithm >> complete: item [
3032
self subclassResponsibility
3133
]
3234

33-
{ #category : #'private template' }
35+
{ #category : 'private template' }
3436
JEAlgorithm >> evaluate: words [
3537
| n chart |
3638
n := words size + 1.
@@ -52,13 +54,13 @@ JEAlgorithm >> evaluate: words [
5254
^ chart
5355
]
5456

55-
{ #category : #initialization }
57+
{ #category : 'initialization' }
5658
JEAlgorithm >> initializeGrammar: aGrammar [
5759
self initialize.
5860
grammar := aGrammar
5961
]
6062

61-
{ #category : #'private operations' }
63+
{ #category : 'private operations' }
6264
JEAlgorithm >> predict: item [
6365
"
6466
Prediction:
@@ -86,7 +88,7 @@ JEAlgorithm >> predict: item [
8688
item finalItemsWithHeadIsSymbolAtDotDo: [ :again | self complete: again ]
8789
]
8890

89-
{ #category : #'private operations' }
91+
{ #category : 'private operations' }
9092
JEAlgorithm >> scan: item with: word at: column [
9193
"scan: add a new item with the dot move forward, over the recently scan terminal.
9294
If a is the next input symbol

‎repository/EarleyParser-Core/JEBSPPFVisitor.class.st‎

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,69 +8,71 @@ Visitor.
88
99
"
1010
Class {
11-
#name : #JEBSPPFVisitor,
12-
#superclass : #Object,
11+
#name : 'JEBSPPFVisitor',
12+
#superclass : 'Object',
1313
#instVars : [
1414
'postOrderFamilyBlock',
1515
'postOrderNodeBlock',
1616
'preOrderFamilyBlock',
1717
'preOrderNodeBlock'
1818
],
19-
#category : #'EarleyParser-Core-BSPPForest'
19+
#category : 'EarleyParser-Core-BSPPForest',
20+
#package : 'EarleyParser-Core',
21+
#tag : 'BSPPForest'
2022
}
2123

22-
{ #category : #initialization }
24+
{ #category : 'initialization' }
2325
JEBSPPFVisitor >> postOrderFamilyBlock: aBlockWithOneArgument [
2426
postOrderFamilyBlock := aBlockWithOneArgument
2527
]
2628

27-
{ #category : #initialization }
29+
{ #category : 'initialization' }
2830
JEBSPPFVisitor >> postOrderNodeBlock: aBlockWithOneArgument [
2931
postOrderNodeBlock := aBlockWithOneArgument
3032
]
3133

32-
{ #category : #initialization }
34+
{ #category : 'initialization' }
3335
JEBSPPFVisitor >> preOrderFamilyBlock: aBlockWithOneArgument [
3436
preOrderFamilyBlock := aBlockWithOneArgument
3537
]
3638

37-
{ #category : #initialization }
39+
{ #category : 'initialization' }
3840
JEBSPPFVisitor >> preOrderNodeBlock: aBlockWithOneArgument [
3941
preOrderNodeBlock := aBlockWithOneArgument
4042
]
4143

42-
{ #category : #visiting }
44+
{ #category : 'visiting' }
4345
JEBSPPFVisitor >> visit: aBSPPForest [
4446
aBSPPForest acceptVisitor: self
4547
]
4648

47-
{ #category : #visiting }
49+
{ #category : 'visiting' }
4850
JEBSPPFVisitor >> visitNode: aPackedOrFamilyNode [
4951
self subclassResponsibility
5052
]
5153

52-
{ #category : #visiting }
54+
{ #category : 'visiting' }
5355
JEBSPPFVisitor >> visitPostOrderFamily: aFamily [
5456
"visit in post-order a family"
5557

5658
postOrderFamilyBlock ifNotNil: [ postOrderFamilyBlock cull: aFamily ]
5759
]
5860

59-
{ #category : #visiting }
61+
{ #category : 'visiting' }
6062
JEBSPPFVisitor >> visitPostOrderPackedNode: aPackedNode [
6163
"visit in post-order a node"
6264

6365
postOrderNodeBlock ifNotNil: [ postOrderNodeBlock cull: aPackedNode ]
6466
]
6567

66-
{ #category : #visiting }
68+
{ #category : 'visiting' }
6769
JEBSPPFVisitor >> visitPreOrderFamily: aFamily [
6870
"visit in pre-order a family"
6971

7072
preOrderFamilyBlock ifNotNil: [ preOrderFamilyBlock cull: aFamily ]
7173
]
7274

73-
{ #category : #visiting }
75+
{ #category : 'visiting' }
7476
JEBSPPFVisitor >> visitPreOrderPackedNode: aPackedNode [
7577
"visit in pre-order a node"
7678

‎repository/EarleyParser-Core/JEBSPPForest.class.st‎

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,32 @@ Forest
77
88
"
99
Class {
10-
#name : #JEBSPPForest,
11-
#superclass : #Object,
10+
#name : 'JEBSPPForest',
11+
#superclass : 'Object',
1212
#instVars : [
1313
'root'
1414
],
15-
#category : #'EarleyParser-Core-BSPPForest'
15+
#category : 'EarleyParser-Core-BSPPForest',
16+
#package : 'EarleyParser-Core',
17+
#tag : 'BSPPForest'
1618
}
1719

18-
{ #category : #'instance creation' }
20+
{ #category : 'instance creation' }
1921
JEBSPPForest class >> root: aPackedNode [
2022
^ self basicNew initializeRoot: aPackedNode
2123
]
2224

23-
{ #category : #visiting }
25+
{ #category : 'visiting' }
2426
JEBSPPForest >> acceptVisitor: aVisitor [
2527
aVisitor visitNode: root
2628
]
2729

28-
{ #category : #initialization }
30+
{ #category : 'initialization' }
2931
JEBSPPForest >> initializeRoot: aPackedNode [
3032
root := aPackedNode
3133
]
3234

33-
{ #category : #testing }
35+
{ #category : 'testing' }
3436
JEBSPPForest >> numberOfTrees [
3537
"depth visit from the root node. return the number of trees from the root node"
3638

@@ -52,7 +54,7 @@ JEBSPPForest >> numberOfTrees [
5254
^ numberOfTrees at: root
5355
]
5456

55-
{ #category : #printing }
57+
{ #category : 'printing' }
5658
JEBSPPForest >> printOn: aStream [
5759
aStream
5860
print: self class;
@@ -61,7 +63,7 @@ JEBSPPForest >> printOn: aStream [
6163
nextPut: $)
6264
]
6365

64-
{ #category : #'initialize-release' }
66+
{ #category : 'initialize-release' }
6567
JEBSPPForest >> release [
6668
root release.
6769
root := nil.

0 commit comments

Comments
 (0)