Skip to content

Commit ffc0046

Browse files
clean: Improve doc and fix typos etc. found by Gemini Code Assist review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent eda6f43 commit ffc0046

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

docs/concepts/mcp.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,14 @@ The 🔱 [Model Context Protocol](https://modelcontextprotocol.io) (MCP) is a st
2222

2323
## Configuration
2424

25-
See [`mcp.yaml`](https://github.com/enola-dev/enola/blob/main/models/enola.dev/ai/mcp.yaml).
25+
The `--mcp` CLI argument specifies which MCP servers are available to Agents.
26+
27+
If not specified it uses the built-in [`mcp.yaml`](https://github.com/enola-dev/enola/blob/main/models/enola.dev/ai/mcp.yaml) by default.
2628

2729
Use the names under the `servers:` key of a `mcp.yaml` in the `tools:` of [Agents](agent.md).
2830

31+
MCP servers are only started (or connected to), and queried for their 🧰 Tools, if any of the loaded `--agents` use them.
32+
2933
<!--
3034
## Recommended
3135
@@ -54,7 +58,7 @@ enola ai --agents=test/agents/everything.agent.yaml --in "Print environment vari
5458

5559
### Fetch
5660

57-
The [`fetch` MCP server](https://github.com/modelcontextprotocol/servers/tree/main/src/everything) can fetch a webpage, and extract its contents as Markdown:
61+
The [`fetch` MCP server](https://github.com/modelcontextprotocol/servers/tree/main/src/fetch) can fetch a webpage, and extract its contents as Markdown:
5862

5963
```shell
6064
enola ai -a test/agents/fetch.agent.yaml --in="What is on https://docs.enola.dev/tutorial/agents/ ?"

java/dev/enola/ai/mcp/cli/McpOptions.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,18 @@ public class McpOptions {
4040
description =
4141
"URL/s of MCP Configurations; see"
4242
+ " https://docs.enola.dev/concepts/mcp/#configuration")
43-
@Nullable List<URI> agentURIs;
43+
@Nullable List<URI> mcpConfigURIs;
4444

4545
public static McpOptions handleDefault(@Nullable McpOptions mcpOptions) {
4646
if (mcpOptions == null) {
4747
mcpOptions = new McpOptions();
48-
mcpOptions.agentURIs = List.of(URI.create(McpOptions.DEFAULT_MCP_YAML));
48+
mcpOptions.mcpConfigURIs = List.of(URI.create(McpOptions.DEFAULT_MCP_YAML));
4949
}
5050
return mcpOptions;
5151
}
5252

5353
public void load(McpLoader loader, ResourceProvider rp) throws IOException {
54-
if (agentURIs == null) return;
55-
for (var uri : agentURIs) loader.load(rp.getNonNull(uri));
54+
if (mcpConfigURIs == null) return;
55+
for (var uri : mcpConfigURIs) loader.load(rp.getNonNull(uri));
5656
}
5757
}

models/enola.dev/ai/mcp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ servers:
2828
# Exercise caution when using this MCP server to ensure this does not expose any sensitive data!
2929
command: uvx
3030
args: [mcp-server-fetch]
31-
origin: https://github.com//servers/tree/main/src/fetch
31+
origin: https://github.com/modelcontextprotocol/servers/tree/main/src/fetch
3232

3333
inputs:

0 commit comments

Comments
 (0)