feat: integrate cargo into cmake build (#2690)

Author: 0ax1

duckdb-vortex/CMakeLists.txt

@@ -1,30 +1,39 @@
-cmake_minimum_required(VERSION 3.5)
+cmake_minimum_required(VERSION 3.22)
 
 # Set extension name here
 set(TARGET_NAME vortex_duckdb)
+set(EXTENSION_NAME ${TARGET_NAME}_extension)
+set(EXTENSION_SOURCES src/vortex_duckdb_extension.cpp)
+set(LOADABLE_EXTENSION_NAME ${TARGET_NAME}_loadable_extension)
 
-# DuckDB's extension distribution supports vcpkg. As such, dependencies can be added in ./vcpkg.json and then
-# used in cmake with find_package. Feel free to remove or replace with other dependencies.
-# Note that it should also be removed from vcpkg.json to prevent needlessly installing it..
+# DuckDB's extension distribution supports vcpkg. As such, dependencies can be
+# added in ./vcpkg.json and then used in cmake with find_package. Feel free to
+# remove or replace with other dependencies. Note that it should also be removed
+# from vcpkg.json to prevent needlessly installing it..
 find_package(OpenSSL REQUIRED)
 
-set(EXTENSION_NAME ${TARGET_NAME}_extension)
-set(LOADABLE_EXTENSION_NAME ${TARGET_NAME}_loadable_extension)
+include(FetchContent)
+FetchContent_Declare(
+    Corrosion
+    GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git
+    GIT_TAG v0.5.1
+)
+FetchContent_MakeAvailable(Corrosion)
 
-project(${TARGET_NAME})
-include_directories(src/include)
+# Import targets defined in a package or workspace manifest `Cargo.toml` file
+corrosion_import_crate(MANIFEST_PATH ${CMAKE_CURRENT_SOURCE_DIR}/../vortex-duckdb/Cargo.toml)
 
-set(EXTENSION_SOURCES src/vortex_duckdb_extension.cpp)
+project(${TARGET_NAME}_project)
+include_directories(src/include)
 
 build_static_extension(${TARGET_NAME} ${EXTENSION_SOURCES})
 build_loadable_extension(${TARGET_NAME} " " ${EXTENSION_SOURCES})
 
-# Link OpenSSL in both the static library as the loadable extension
-target_link_libraries(${EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto)
-target_link_libraries(${LOADABLE_EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto)
+target_link_libraries(${EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto vortex_duckdb-static)
+target_link_libraries(${LOADABLE_EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto vortex_duckdb-shared)
 
 install(
   TARGETS ${EXTENSION_NAME}
   EXPORT "${DUCKDB_EXPORT_SET}"
   LIBRARY DESTINATION "${INSTALL_LIB_DIR}"
-  ARCHIVE DESTINATION "${INSTALL_LIB_DIR}")
+  ARCHIVE DESTINATION "${INSTALL_LIB_DIR}")

duckdb-vortex/duckdb

@@ -47,6 +47,7 @@ static void LoadInternal(DatabaseInstance &instance) {
 void VortexDuckdbExtension::Load(DuckDB &db) {
 	LoadInternal(*db.instance);
 }
+
 std::string VortexDuckdbExtension::Name() {
 	return "vortex_duckdb";
 }

duckdb-vortex/src/vortex_duckdb_extension.cpp

@@ -17,6 +17,7 @@ readme = { workspace = true }
 name = "vortex_duckdb"
 path = "src/lib.rs"
 bench = false
+crate-type = ["staticlib", "cdylib"]
 
 [dependencies]
 itertools = { workspace = true }
@@ -27,7 +28,5 @@ vortex-error = { workspace = true }
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 duckdb = { workspace = true }
 
-[dev-dependencies]
-
 [lints]
 workspace = true