fix[dict]: not (filter/take) set_all_values_referenced

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-array/src/arrays/dict/compute/cast.rs

@@ -24,7 +24,6 @@ impl CastKernel for DictVTable {
         };
 
         // SAFETY: casting does not alter invariants of the codes
-        // Preserve all_values_referenced since casting only changes values, not which are referenced
         Ok(Some(
             unsafe {
                 DictArray::new_unchecked(casted_codes, casted_values)

vortex-array/src/arrays/dict/compute/fill_null.rs

@@ -44,8 +44,6 @@ impl FillNullKernel for DictVTable {
         // SAFETY: invariants are still satisfied after patching nulls
         unsafe {
             Ok(DictArray::new_unchecked(codes, values)
-                // Preserve all_values_referenced since filling nulls cannot make values
-                // unreferenced.
                 .set_all_values_referenced(array.has_all_values_referenced())
                 .into_array())
         }

vortex-array/src/arrays/dict/compute/mod.rs

@@ -24,11 +24,7 @@ impl TakeKernel for DictVTable {
         let codes = take(array.codes(), indices)?;
         // SAFETY: selecting codes doesn't change the invariants of DictArray
         // Preserve all_values_referenced since taking codes doesn't affect which values are referenced
-        Ok(unsafe {
-            DictArray::new_unchecked(codes, array.values().clone())
-                .set_all_values_referenced(array.has_all_values_referenced())
-                .into_array()
-        })
+        Ok(unsafe { DictArray::new_unchecked(codes, array.values().clone()).into_array() })
     }
 }
 
@@ -40,11 +36,7 @@ impl FilterKernel for DictVTable {
 
         // SAFETY: filtering codes doesn't change invariants
         // Preserve all_values_referenced since filtering codes doesn't affect which values are referenced
-        unsafe {
-            Ok(DictArray::new_unchecked(codes, array.values().clone())
-                .set_all_values_referenced(array.has_all_values_referenced())
-                .into_array())
-        }
+        unsafe { Ok(DictArray::new_unchecked(codes, array.values().clone()).into_array()) }
     }
 }