Skip to content

Commit 0b280bc

Browse files
committed
Immutable session + registries
Signed-off-by: Nicholas Gates <[email protected]>
1 parent ab358e6 commit 0b280bc

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

java/testfiles/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use vortex::dtype::Nullability;
1616
use vortex::file::WriteOptionsSessionExt;
1717
use vortex::io::runtime::current::CurrentThreadRuntime;
1818
use vortex::io::runtime::BlockingRuntime;
19-
use vortex::io::session::RuntimeSessionExt;
19+
use vortex::io::session::RuntimeSessionMutExt;
2020
use vortex::session::VortexSession;
2121
use vortex::VortexSessionDefault;
2222

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,2 @@
11
# SPDX-License-Identifier: Apache-2.0
22
# SPDX-FileCopyrightText: Copyright the Vortex contributors
3-
4-
from vortex._lib.registry import register # pyright: ignore[reportMissingModuleSource]
5-
6-
__all__ = ["register"]

vortex-python/test/test_pyarray.py

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33

44
from __future__ import annotations
55

6-
from typing import final
7-
86
import numpy as np
97
import pyarrow as pa
108
import pytest
@@ -14,6 +12,7 @@
1412
from pcodec import ( # pyright: ignore[reportMissingTypeStubs]
1513
wrapped as pco, # pyright: ignore[reportAttributeAccessIssue, reportUnknownVariableType]
1614
)
15+
from typing import final
1716
from typing_extensions import override
1817

1918
import vortex as vx
@@ -36,21 +35,23 @@ def dtype(self) -> vx.DType:
3635
return self._dtype
3736

3837
def __init__(
39-
self,
40-
length: int,
41-
dtype: vx.DType,
42-
file_header: memoryview,
43-
chunk_header: memoryview,
44-
data: memoryview,
38+
self,
39+
length: int,
40+
dtype: vx.DType,
41+
file_header: memoryview,
42+
chunk_header: memoryview,
43+
data: memoryview,
4544
):
46-
(fd, _bytes_read) = pco.FileDecompressor.new(file_header) # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
45+
(fd, _bytes_read) = pco.FileDecompressor.new(
46+
file_header) # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
4747

4848
if dtype == vx.int_(64, nullable=True):
4949
dt = "i64"
5050
else:
5151
raise ValueError(f"Unsupported dtype: {dtype}")
5252

53-
(cd, _bytes_read) = fd.read_chunk_meta(chunk_header, dt) # pyright: ignore[reportUnknownVariableType, reportUnknownMemberType]
53+
(cd, _bytes_read) = fd.read_chunk_meta(chunk_header,
54+
dt) # pyright: ignore[reportUnknownVariableType, reportUnknownMemberType]
5455

5556
dst = np.array([0] * length, dtype=np.int64)
5657
cd.read_page_into( # pyright: ignore[reportUnknownMemberType]
@@ -66,19 +67,22 @@ def __init__(
6667
self._data = data
6768

6869
@classmethod
69-
def encode(cls, array: pa.Array[pa.Scalar[pa.DataType]], config: ChunkConfig | None = None) -> PCodecArray: # pyright: ignore[reportUnknownParameterType]
70+
def encode(cls, array: pa.Array[pa.Scalar[pa.DataType]],
71+
config: ChunkConfig | None = None) -> PCodecArray: # pyright: ignore[reportUnknownParameterType]
7072
assert array.null_count == 0, "Cannot compress arrays with nulls"
7173

7274
config = config or ChunkConfig() # pyright: ignore[reportUnknownVariableType]
7375

7476
fc = pco.FileCompressor() # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
7577
file_header = fc.write_header() # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
7678

77-
cc = fc.chunk_compressor(array.to_numpy(), config) # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
79+
cc = fc.chunk_compressor(array.to_numpy(),
80+
config) # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
7881
chunk_header = cc.write_chunk_meta() # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
7982

8083
data = b""
81-
for i, _n in enumerate(cc.n_per_page()): # pyright: ignore[reportUnknownMemberType, reportUnknownArgumentType, reportUnknownVariableType]
84+
for i, _n in enumerate(
85+
cc.n_per_page()): # pyright: ignore[reportUnknownMemberType, reportUnknownArgumentType, reportUnknownVariableType]
8286
data += cc.write_page(i) # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType]
8387

8488
return PCodecArray(
@@ -101,4 +105,4 @@ def decode(cls, parts: vx.ArrayParts, ctx: vx.ArrayContext, dtype: vx.DType, len
101105
def test_pcodec():
102106
_ = PCodecArray.encode(pa.array([0, 1, 2, 3, 4])) # pyright: ignore[reportUnknownMemberType]
103107

104-
vx.registry.register(PCodecArray)
108+
# vx.registry.register(PCodecArray)

0 commit comments

Comments
 (0)