Skip to content

Commit 10e84ca

Browse files
fix: compression benchmark (#3339)
Build the duckdb extension explicitly Signed-off-by: Joe Isaacs <[email protected]>
1 parent 83a675d commit 10e84ca

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed

.github/workflows/bench-pr.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,18 @@ jobs:
9898
run: |
9999
echo "${{ github.workspace }}/duckdb/build/release/" >> $GITHUB_PATH
100100
101+
- name: Install ninja and gzip
102+
run: sudo apt-get update && sudo apt-get install -y gzip ninja-build
103+
104+
- name: DuckDB extension build
105+
env:
106+
# Build DuckDB and the Vortex extension with `-march=native`.
107+
# The `NATIVE_ARCH` environment variable is picked up by `duckdb/Makefile`.
108+
NATIVE_ARCH: 1
109+
DUCKDB_PLATFORM: linux_amd64
110+
run: GEN=ninja make release
111+
working-directory: ${{ github.workspace }}/duckdb-vortex
112+
101113
- name: Build binary
102114
shell: bash
103115
env:

.github/workflows/bench.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,15 @@ jobs:
107107
- name: Install gzip
108108
run: sudo apt-get update && sudo apt-get install -y gzip ninja-build
109109

110+
- name: DuckDB extension build
111+
env:
112+
# Build DuckDB and the Vortex extension with `-march=native`.
113+
# The `NATIVE_ARCH` environment variable is picked up by `duckdb/Makefile`.
114+
NATIVE_ARCH: 1
115+
DUCKDB_PLATFORM: linux_amd64
116+
run: GEN=ninja make release
117+
working-directory: ${{ github.workspace }}/duckdb-vortex
118+
110119
# rustup is pre-installed on the ubuntu24-full-x64 image.
111120
- name: Run ${{ matrix.benchmark.name }} benchmark
112121
shell: bash

bench-vortex/src/datasets/tpch_l_comment.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use vortex::dtype::FieldName;
44
use vortex::{ArrayRef, IntoArray, ToCanonical};
55

66
use crate::datasets::Dataset;
7-
use crate::ddb::{build_vortex_duckdb, duckdb_executable_path};
7+
use crate::ddb::duckdb_executable_path;
88
use crate::tpch::duckdb::{DuckdbTpcOptions, TpcDataset, generate_tpc};
99
use crate::{Format, IdempotentPath, tpch};
1010

@@ -17,8 +17,6 @@ impl Dataset for TPCHLCommentChunked {
1717
}
1818

1919
async fn to_vortex_array(&self) -> ArrayRef {
20-
// TODO(joe): replace with a duckdb binary
21-
build_vortex_duckdb();
2220
let duckdb_resolved_path = duckdb_executable_path(&None);
2321
let opts = DuckdbTpcOptions::new("tpch".to_data_path(), TpcDataset::TpcH, Format::Csv)
2422
.with_duckdb_path(duckdb_resolved_path.clone());

0 commit comments

Comments
 (0)