Skip to content

Commit 10f5345

Browse files
authored
Stop enabling pyo3/extension-modules by default (#4992)
See [this](https://pyo3.rs/main/building-and-distribution#the-extension-module-feature) section the pyo3's docs. We already enable it when building the whl with maturin. --------- Signed-off-by: Adam Gutglick <[email protected]>
1 parent db90720 commit 10f5345

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

.cargo/config.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,4 @@ timeout = 3600
2020

2121
# Environment variables for PyO3. Ensures reproducible builds and avoids spurious recompilations.
2222
[env]
23-
PYO3_PYTHON = { value = ".venv/bin/python", relative = true, force = true }
2423
PYO3_ENVIRONMENT_SIGNATURE = { value = "cpython-3.11-64bit", force = true }

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ primitive-types = { version = "0.14.0" }
155155
prost = "0.14"
156156
prost-build = "0.14"
157157
prost-types = "0.14"
158-
pyo3 = { version = "0.26.0", features = ["extension-module", "abi3-py310"] }
158+
pyo3 = { version = "0.26.0" }
159159
pyo3-log = "0.13.0"
160160
rand = "0.9.0"
161161
rand_distr = "0.5"

vortex-python/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ log = { workspace = true }
3030
mimalloc = { workspace = true }
3131
object_store = { workspace = true, features = ["aws", "gcp", "azure", "http"] }
3232
parking_lot = { workspace = true }
33-
pyo3 = { workspace = true, features = ["abi3-py311"] }
33+
pyo3 = { workspace = true, features = ["abi3", "abi3-py311"] }
3434
pyo3-log = { workspace = true }
3535
tokio = { workspace = true, features = ["fs", "rt-multi-thread"] }
3636
url = { workspace = true }

0 commit comments

Comments
 (0)