wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-array/src/arrays/decimal/array.rs

@@ -5,13 +5,12 @@ use itertools::Itertools;
 use vortex_buffer::{BitBufferMut, Buffer, BufferMut, ByteBuffer};
 use vortex_dtype::{
     BigCast, DType, DecimalDType, DecimalType, IntegerPType, NativeDecimalType,
-    match_each_integer_ptype,
+    is_compatible_decimal_value_type, match_each_integer_ptype,
 };
 use vortex_error::{VortexExpect, VortexResult, vortex_ensure, vortex_panic};
 use vortex_scalar::match_each_decimal_value_type;
 
 use crate::ToCanonical;
-use crate::arrays::is_compatible_decimal_value_type;
 use crate::patches::Patches;
 use crate::stats::ArrayStats;
 use crate::validity::Validity;

vortex-array/src/arrays/decimal/utils.rs

@@ -2,18 +2,12 @@
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 use itertools::{Itertools, MinMaxResult};
-use vortex_dtype::{DecimalDType, smallest_decimal_value_type};
 use vortex_error::VortexExpect;
 use vortex_scalar::{DecimalType, i256};
 
 use crate::arrays::DecimalArray;
 use crate::vtable::ValidityHelper;
 
-/// True if `value_type` can represent every value of the type `dtype`.
-pub fn is_compatible_decimal_value_type(value_type: DecimalType, dtype: DecimalDType) -> bool {
-    value_type >= smallest_decimal_value_type(&dtype)
-}
-
 macro_rules! try_downcast {
     ($array:expr, from: $src:ty, to: $($dst:ty),*) => {{
         use vortex_dtype::BigCast;

vortex-dtype/src/decimal/smallest_type.rs

@@ -16,3 +16,8 @@ pub fn smallest_decimal_value_type(decimal_dtype: &DecimalDType) -> DecimalType
         p => unreachable!("precision larger than 76 is invalid found precision {p}"),
     }
 }
+
+/// True if `value_type` can represent every value of the type `dtype`.
+pub fn is_compatible_decimal_value_type(value_type: DecimalType, dtype: DecimalDType) -> bool {
+    value_type >= smallest_decimal_value_type(&dtype)
+}