Skip to content

Commit 15afa7b

Browse files
committed
fix[array]: fill_null don't run utf8 or binary
Signed-off-by: Joe Isaacs <[email protected]>
1 parent 925c956 commit 15afa7b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

fuzz/src/array/mod.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -381,8 +381,8 @@ fn actions_for_dtype(dtype: &DType) -> HashSet<ActionType> {
381381
[Compress, Slice, Take, Filter, MinMax, Mask, ScalarAt].into()
382382
}
383383
DType::Utf8(_) | DType::Binary(_) => {
384-
// Utf8/Binary supports everything except Sum
385-
// Actions: Compress, Slice, Take, SearchSorted, Filter, Compare, Cast, MinMax, FillNull, Mask, ScalarAt
384+
// Utf8/Binary supports everything except Sum and FillNull
385+
// Actions: Compress, Slice, Take, SearchSorted, Filter, Compare, Cast, MinMax, Mask, ScalarAt
386386
[
387387
Compress,
388388
Slice,
@@ -392,7 +392,6 @@ fn actions_for_dtype(dtype: &DType) -> HashSet<ActionType> {
392392
Compare,
393393
Cast,
394394
MinMax,
395-
FillNull,
396395
Mask,
397396
ScalarAt,
398397
]

vortex-array/src/compute/fill_null.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ impl ComputeFnVTable for FillNull {
108108
return Ok(fill_null(canonical_arr.as_ref(), fill_value)?.into());
109109
}
110110

111+
// TODO(joe): fill_null not implemented for DType Binary
111112
vortex_bail!("fill null not implemented for DType {}", array.dtype())
112113
}
113114

0 commit comments

Comments
 (0)