Skip to content

Commit 1d668f6

Browse files
committed
Merge develop
Signed-off-by: Nicholas Gates <[email protected]>
1 parent f014507 commit 1d668f6

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

vortex-array/src/expr/exprs/list_contains.rs

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ use std::ops::Deref;
77

88
use arrow_buffer::bit_iterator::BitIndexIterator;
99
use vortex_buffer::BitBuffer;
10-
use vortex_compute::comparison::Compare;
11-
use vortex_compute::comparison::Equal;
1210
use vortex_compute::logical::LogicalOr;
1311
use vortex_dtype::DType;
1412
use vortex_dtype::IntegerPType;
@@ -301,7 +299,17 @@ fn constant_list_scalar_contains(list: ListViewScalar, values: Vector) -> Vortex
301299
);
302300
for i in 0..elements.len() {
303301
let element = Datum::Scalar(elements.scalar_at(i));
304-
let compared: BoolDatum = Compare::<Equal>::compare(Datum::Vector(values.clone()), element);
302+
let compared: BoolDatum = Binary
303+
.bind(operators::Operator::Eq)
304+
.execute(ExecutionArgs {
305+
datums: vec![Datum::Vector(values.clone()), element],
306+
dtypes: vec![
307+
// FIXME(ngates): call compute function directly!
308+
],
309+
row_count: values.len(),
310+
return_dtype: DType::Bool(Nullability::Nullable),
311+
})?
312+
.into_bool();
305313
let compared = Datum::from(compared)
306314
.ensure_vector(values.len())
307315
.into_bool();

0 commit comments

Comments
 (0)